Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 6573006: Remove all functionality from class HSubgraph. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Remove all functionality from class HSubgraph. Move the member functions of HSubgraph to HGraphBuilder. Committed: http://code.google.com/p/v8/source/detail?r=6958

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -204 lines) Patch
M src/hydrogen.h View 3 chunks +31 lines, -33 lines 0 comments Download
M src/hydrogen.cc View 20 chunks +149 lines, -171 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
All the AppendXXX functions on HSubgraph moved to HGraphBuilder. I elected to name them CreateXXX ...
9 years, 10 months ago (2011-02-23 16:49:17 UTC) #1
fschneider
LGTM. http://codereview.chromium.org/6573006/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/6573006/diff/1/src/hydrogen.cc#newcode552 src/hydrogen.cc:552: } else { here you could write } ...
9 years, 10 months ago (2011-02-24 13:09:44 UTC) #2
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-28 08:53:29 UTC) #3
http://codereview.chromium.org/6573006/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6573006/diff/1/src/hydrogen.cc#newcode552
src/hydrogen.cc:552: } else {
On 2011/02/24 13:09:44, fschneider wrote:
> here you could write 
> 
> } else if (...) {
> 
> }

Good catch.  I'll hold off for now because the "if (blah != NULL)
blah->Goto(whocares);" seems like an idiom that we might abstract, so I'd like
to keep it exactly that way in the code.

Powered by Google App Engine
This is Rietveld 408576698