Issue 6573004: ARM: Fix DoubleToI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6573004: ARM: Fix DoubleToI (Closed)

Created:
9 years, 10 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Fix DoubleToI. BUG=1811 TEST=test/mjsunit/regress/regress-1181.js

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -9 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+17 lines, -9 lines	0 comments	Download
	A	test/mjsunit/regress/regress-1181.js	View	1	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 10 months ago (2011-02-24 09:09:17 UTC) #2

LGTM

http://codereview.chromium.org/6573004/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6573004/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:3392: if (!instr->truncating()) {
Please add a comment here explaining the conversion back to double.

http://codereview.chromium.org/6573004/diff/1/test/mjsunit/regress/regress-11...
File test/mjsunit/regress/regress-1181.js (right):

http://codereview.chromium.org/6573004/diff/1/test/mjsunit/regress/regress-11...
test/mjsunit/regress/regress-1181.js:39: for(var x=0; x < 150; x++){
As this is timing specific, maybe wrap this in a function and pass different
values for "150" to cover a broader range.

Expand Messages | Collapse Messages