Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 6573: It turns out that we were only "failing" the iframe-onload-remove-self-no-cra... (Closed)

Created:
12 years, 2 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
Feng Qian, ojan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

It turns out that we were only "failing" the iframe-onload-remove-self-no-crash.html because of an unrelated change in how WebCore renders an element. This test really should have been using dumpAsText instead of comparing the page rendering. R=ojan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2986

Patch Set 1 #

Patch Set 2 : '' #

Messages

Total messages: 5 (0 generated)
darin (slow to review)
12 years, 2 months ago (2008-10-08 01:01:01 UTC) #1
darin (slow to review)
12 years, 2 months ago (2008-10-08 01:01:13 UTC) #2
darin (slow to review)
12 years, 2 months ago (2008-10-08 01:01:20 UTC) #3
ojan
LGTM
12 years, 2 months ago (2008-10-08 01:03:02 UTC) #4
Feng Qian
12 years, 2 months ago (2008-10-15 21:49:08 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698