Issue 6572001: Use libjpeg-turbo as the default JPEG library (Take 2)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6572001: Use libjpeg-turbo as the default JPEG library (Take 2)... (Closed)

Created:
9 years, 10 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, jamesr, jschuh, Timur Iskhodzhanov, Evan Martin

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use libjpeg-turbo as the default JPEG library (Take 2) This change retries using libjpeg-turbo (r75235), which fixed memory errors, as the default JPEG library of Chromium. BUG=48789, 72399 TEST=JPEGCodec.InvalidRead Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76198

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings, Since trybots do not make any memory errors related to libjpeg-turbo, I would like ...

9 years, 10 months ago (2011-02-24 11:00:24 UTC) #1

Timur Iskhodzhanov

LGTM provided Valgrind hasn't found anything on the trybot/locally.

9 years, 10 months ago (2011-02-24 11:08:09 UTC) #2

Hironori Bono

9 years, 9 months ago (2011-02-28 03:58:38 UTC) #5

Greetings James,

I think I just forgot clobbering the bot because this change requires clobber
builds on Mac. Can you please give me the bot name?

Regards,

Hironori Bono

Expand Messages | Collapse Messages