AllignFrame/CallCFuntion moved from regexp-macro-assembler-ia32 to macro-asse...

AllignFrame/CallCFuntion moved from regexp-macro-assembler-ia32 to macro-assembler-ia32 (like in x64 version).


Committed: http://code.google.com/p/v8/source/detail?r=3947

[Søren Thygesen Gjesse, 2010-02-24 22:35:39]

LGTM

http://codereview.chromium.org/657080/diff/1/5
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/657080/diff/1/5#newcode1626
src/ia32/macro-assembler-ia32.cc:1626: // TODO(lrn): Since we no longer use the
system stack arbitrarily (but we do
Please remove this comment. I don't think it makes sense any more.

http://codereview.chromium.org/657080/diff/1/5#newcode1645
src/ia32/macro-assembler-ia32.cc:1645: int num_arguments) {
Please make a comment here that trashing eax is ok as it will be the return
value.

[Søren Thygesen Gjesse, 2010-02-25 09:46:01]

On 2010/02/24 22:35:39, Søren Gjesse wrote:
> LGTM
> 
> http://codereview.chromium.org/657080/diff/1/5
> File src/ia32/macro-assembler-ia32.cc (right):
> 
> http://codereview.chromium.org/657080/diff/1/5#newcode1626
> src/ia32/macro-assembler-ia32.cc:1626: // TODO(lrn): Since we no longer use
the
> system stack arbitrarily (but we do
> Please remove this comment. I don't think it makes sense any more.
> 
> http://codereview.chromium.org/657080/diff/1/5#newcode1645
> src/ia32/macro-assembler-ia32.cc:1645: int num_arguments) {
> Please make a comment here that trashing eax is ok as it will be the return
> value.

I just looked at CodeGenerator::GenerateRandomPositiveSmi, and we should use
your new macro assembler functions there as well.

[SeRya, 2010-02-25 11:57:33]

CodeGenerator::GenerateRandomPositiveSmi fixed (both ia32 and x64).

http://codereview.chromium.org/657080/diff/1/5
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/657080/diff/1/5#newcode1626
src/ia32/macro-assembler-ia32.cc:1626: // TODO(lrn): Since we no longer use the
system stack arbitrarily (but we do
On 2010/02/24 22:35:39, Søren Gjesse wrote:
> Please remove this comment. I don't think it makes sense any more.

Done.

http://codereview.chromium.org/657080/diff/1/5#newcode1645
src/ia32/macro-assembler-ia32.cc:1645: int num_arguments) {
On 2010/02/24 22:35:39, Søren Gjesse wrote:
> Please make a comment here that trashing eax is ok as it will be the return
> value.

Done.

[Søren Thygesen Gjesse, 2010-02-25 12:29:21]

Minor comment.

http://codereview.chromium.org/657080/diff/2017/2018
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/657080/diff/2017/2018#newcode5746
src/ia32/codegen-ia32.cc:5746: int num_arguments = 0;
Please change this to static const.

http://codereview.chromium.org/657080/diff/2017/2023
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/657080/diff/2017/2023#newcode3961
src/x64/codegen-x64.cc:3961: int num_arguments = 0;
Please change this to static const.