Issue 657027: Updated image_to_vmware.sh to generate an VMware configuration file. This is useful for VMplayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 657027: Updated image_to_vmware.sh to generate an VMware configuration file. This is useful for VMplayer. (Closed)

Created:
10 years, 10 months ago by raiford

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
raiford

Visibility:
Public.

Description

Updated image_to_vmware.sh to generate an VMware configuration file. This is useful for VMplayer. BUG=None Test=Run "vmplayer chromeos.vmx" on and verify that the VM boots.

Patch Set 1 #

Total comments: 4

Patch Set 2 : adding comments about memory units. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -5 lines)			Patch
	M	src/scripts/image_to_vmware.sh	View	1	3 chunks	+44 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

raiford

This change will generate a VMware file which can be use with VMplayer. This allows ...

10 years, 10 months ago (2010-02-25 17:13:14 UTC) #1

adlr

LGTM. please just fix the comments. you'll make many people happy with this change. thanks! ...

10 years, 10 months ago (2010-02-25 18:34:25 UTC) #2

raiford

10 years, 10 months ago (2010-02-25 18:56:18 UTC) #3

Fixed the comments.  Will dcommit next.

http://codereview.chromium.org/657027/diff/1/2
File src/scripts/image_to_vmware.sh (right):

http://codereview.chromium.org/657027/diff/1/2#newcode20
src/scripts/image_to_vmware.sh:20: DEFAULT_MEM="1024"
On 2010/02/25 18:34:25, adlr wrote:
> comment w/ units

Done.

http://codereview.chromium.org/657027/diff/1/2#newcode34
src/scripts/image_to_vmware.sh:34: "Memory size for the vmware config."
On 2010/02/25 18:34:25, adlr wrote:
> specify units in the help string (megs?)
> 

Done.

Expand Messages | Collapse Messages