Issue 6570005: x64: Implement delete property in lithium backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6570005: x64: Implement delete property in lithium backend. (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

x64: Implement delete property in lithium backend. Committed: http://code.google.com/p/v8/source/detail?r=6907

Patch Set 2 : Address comments. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -17 lines)			Patch
M	src/ia32/lithium-ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	3 chunks	+48 lines, -13 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM, with question. http://codereview.chromium.org/6570005/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6570005/diff/1/src/x64/lithium-codegen-x64.cc#newcode3359 src/x64/lithium-codegen-x64.cc:3359: __ movq(rsi, Operand(rbp, StandardFrameConstants::kContextOffset)); I thought ...

9 years, 10 months ago (2011-02-23 10:03:12 UTC) #2

Mads Ager (chromium)

9 years, 10 months ago (2011-02-23 10:11:10 UTC) #3

http://codereview.chromium.org/6570005/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6570005/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:3359: __ movq(rsi, Operand(rbp,
StandardFrameConstants::kContextOffset));
On 2011/02/23 10:03:12, William Hesse wrote:
> I thought that rsi was still guaranteed to contain the context on X64, and was
> only freed up on ia32.  Why is this needed?

You are absolutely right. This is not needed. Thanks.

Expand Messages | Collapse Messages

Issue 6570005: x64: Implement delete property in lithium backend. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages