src/array.js - Issue 6568007: Fix array concat to follow the specification in the presence of element getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/array.js

Issue 6568007: Fix array concat to follow the specification in the presence of element getters. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build-ia32

Patch Set: git utd Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/array.js

diff --git a/src/array.js b/src/array.js

index ef82674d789e2460e10cc2cf5fc995a7ae6bdbc2..ead3710689907cd5d3d9aa843a53b21104e4cc87 100644

--- a/src/array.js

+++ b/src/array.js

@@ -418,7 +418,6 @@ function ArrayPush() {

function ArrayConcat(arg1) { // length == 1

- // TODO: can we just use arguments?

var arg_count = %_ArgumentsLength();

var arrays = new $Array(1 + arg_count);

arrays[0] = this;

« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »