Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/handles-inl.h

Issue 6568007: Fix array concat to follow the specification in the presence of element getters. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build-ia32
Patch Set: git utd Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 18 matching lines...) Expand all
29 #ifndef V8_HANDLES_INL_H_ 29 #ifndef V8_HANDLES_INL_H_
30 #define V8_HANDLES_INL_H_ 30 #define V8_HANDLES_INL_H_
31 31
32 #include "apiutils.h" 32 #include "apiutils.h"
33 #include "handles.h" 33 #include "handles.h"
34 #include "api.h" 34 #include "api.h"
35 35
36 namespace v8 { 36 namespace v8 {
37 namespace internal { 37 namespace internal {
38 38
39 template<class T> 39 template<typename T>
40 Handle<T>::Handle(T* obj) { 40 Handle<T>::Handle(T* obj) {
41 ASSERT(!obj->IsFailure()); 41 ASSERT(!obj->IsFailure());
42 location_ = HandleScope::CreateHandle(obj); 42 location_ = HandleScope::CreateHandle(obj);
43 } 43 }
44 44
45 45
46 template <class T> 46 template <typename T>
47 inline T* Handle<T>::operator*() const { 47 inline T* Handle<T>::operator*() const {
48 ASSERT(location_ != NULL); 48 ASSERT(location_ != NULL);
49 ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue); 49 ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue);
50 return *BitCast<T**>(location_); 50 return *BitCast<T**>(location_);
51 } 51 }
52 52
53 53
54 template <typename T>
55 HandleCell<T>::HandleCell(T* value)
56 : location_(HandleScope::CreateHandle(value)) { }
57
58
59 template <typename T>
60 HandleCell<T>::HandleCell(Handle<T> value)
61 : location_(HandleScope::CreateHandle(*value)) { }
62
63
54 #ifdef DEBUG 64 #ifdef DEBUG
55 inline NoHandleAllocation::NoHandleAllocation() { 65 inline NoHandleAllocation::NoHandleAllocation() {
56 v8::ImplementationUtilities::HandleScopeData* current = 66 v8::ImplementationUtilities::HandleScopeData* current =
57 v8::ImplementationUtilities::CurrentHandleScope(); 67 v8::ImplementationUtilities::CurrentHandleScope();
58 // Shrink the current handle scope to make it impossible to do 68 // Shrink the current handle scope to make it impossible to do
59 // handle allocations without an explicit handle scope. 69 // handle allocations without an explicit handle scope.
60 current->limit = current->next; 70 current->limit = current->next;
61 71
62 level_ = current->level; 72 level_ = current->level;
63 current->level = 0; 73 current->level = 0;
64 } 74 }
65 75
66 76
67 inline NoHandleAllocation::~NoHandleAllocation() { 77 inline NoHandleAllocation::~NoHandleAllocation() {
68 // Restore state in current handle scope to re-enable handle 78 // Restore state in current handle scope to re-enable handle
69 // allocations. 79 // allocations.
70 v8::ImplementationUtilities::HandleScopeData* current = 80 v8::ImplementationUtilities::HandleScopeData* current =
71 v8::ImplementationUtilities::CurrentHandleScope(); 81 v8::ImplementationUtilities::CurrentHandleScope();
72 ASSERT_EQ(0, current->level); 82 ASSERT_EQ(0, current->level);
73 current->level = level_; 83 current->level = level_;
74 } 84 }
75 #endif 85 #endif
76 86
77 87
78 } } // namespace v8::internal 88 } } // namespace v8::internal
79 89
80 #endif // V8_HANDLES_INL_H_ 90 #endif // V8_HANDLES_INL_H_
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698