Callback support for __fastcall and __stdcall functions.

Callback support for __fastcall and __stdcall functions.

Create FunctionTraits specializations that can unwrap function pointers that
are delcared with __fastcall and __stdcall on windows.

Only include these in the Windows build.

BUG=35223
TEST=new unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76174

[awong, 2011-02-24 03:37:20]

This is to let us do stuff like

mesasge_loop.PostClosure(Bind(&PostMessage, 0));

Again, spurred by the messge_loop_unittest.cc

[willchan no longer on Chromium, 2011-02-24 08:00:30]

http://codereview.chromium.org/6561004/diff/4007/base/bind_internal.h
File base/bind_internal.h (right):

http://codereview.chromium.org/6561004/diff/4007/base/bind_internal.h#newcode221
base/bind_internal.h:221: #if defined(OS_WIN)
Won't this include it within the base::internal namespace? Would that make it so
it's base::internal::base::internal?

What if you moved this to the very beginning of the file? After the other
includes. I think to make this work, you'd have to duplicate the forward
declaration for FunctionTraits in bind_internal_win.h, but that shouldn't be a
big deal.

The only other way I can see of getting this to work is to close the namespaces
here and reopen. It's kinda ugly. And it's nicer to have all the includes at the
top. So I guess I prefer my first suggestion.

Also, don't we need to include build/build_config.h for OS_WIN?

[awong, 2011-02-25 02:07:52]

http://codereview.chromium.org/6561004/diff/4007/base/bind_internal.h
File base/bind_internal.h (right):

http://codereview.chromium.org/6561004/diff/4007/base/bind_internal.h#newcode221
base/bind_internal.h:221: #if defined(OS_WIN)
On 2011/02/24 08:00:30, willchan wrote:
> Won't this include it within the base::internal namespace? Would that make it
so
> it's base::internal::base::internal?

Whoa...crap...yes it does.  I have no clue how this even compiled.  Something
weird must be happening with the namespace lookup.


> What if you moved this to the very beginning of the file? After the other
> includes. I think to make this work, you'd have to duplicate the forward
> declaration for FunctionTraits in bind_internal_win.h, but that shouldn't be a
> big deal.
> 
> The only other way I can see of getting this to work is to close the
namespaces
> here and reopen. It's kinda ugly. And it's nicer to have all the includes at
the
> top. So I guess I prefer my first suggestion.

 
> Also, don't we need to include build/build_config.h for OS_WIN?

Didn't realize it was declared there. Including.

[willchan no longer on Chromium, 2011-02-25 21:52:09]

LGTM

http://codereview.chromium.org/6561004/diff/6002/base/bind_internal.h.pump
File base/bind_internal.h.pump (right):

http://codereview.chromium.org/6561004/diff/6002/base/bind_internal.h.pump#ne...
base/bind_internal.h.pump:18: #include "build/build_config.h"
You can sort this alphabetically, it'll still be ahead of the defined(OS_WIN)
since that goes last, as specified in
https://sites.google.com/a/chromium.org/dev/developers/coding-style#TOC-Platf....