Issue 6561003: Remove the workaround for bug 43461. Use a g_use_system_ssl...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6561003: Remove the workaround for bug 43461. Use a g_use_system_ssl... (Closed)

Created:
9 years, 10 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Ryan Hamilton

CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Remove the workaround for bug 43461. Use a g_use_system_ssl boolean flag in DefaultClientSocketFactory::CreateSSLClientSocket. Based on rch's code in http://codereview.chromium.org/6487012. R=rch BUG=43461 TEST=no ChromeFrame test program build failures. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75791

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -72 lines)			Patch
M	chrome/browser/browser_main_mac.mm	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_main_win.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	net/base/run_all_unittests.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	net/socket/client_socket_factory.h	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	net/socket/client_socket_factory.cc	View	4 chunks	+33 lines, -34 lines	0 comments	Download
M	webkit/tools/test_shell/simple_resource_loader_bridge.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

wtc

rch: I extracted the UseSystemSSL parts from your CL. I'd like to see if this ...

9 years, 10 months ago (2011-02-23 03:19:06 UTC) #1

Change committed as 75791