Issue 656014: Add '-ldl' to Linux targets that use dynamic loader functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 656014: Add '-ldl' to Linux targets that use dynamic loader functions. (Closed)

Created:
10 years, 10 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Add '-ldl' to Linux targets that use dynamic loader functions. This fixes compilation errors on Karmic, where dlopen() and friends were undefined: http://chrome-buildbot.corp.google.com:8016/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/7777/steps/compile/logs/stdio The missing '-ldl' is papered over on Hardy because pretty much everything depends on gtk, which brings that in through pkg-config, but pkg-config gtk no longer includes '-ldl' on Karmic.

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -0 lines)			Patch
M	base/base.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	gpu/gpu.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Moss

This probably doesn't catch all the instances where we should be explicit about '-ldl', but ...

10 years, 10 months ago (2010-02-23 19:10:47 UTC) #1

LGTM++