Moved creation of GPU transfer buffers into the browser process....

chrome/common/gpu_messages_internal.h

Index: chrome/common/gpu_messages_internal.h
===================================================================
--- chrome/common/gpu_messages_internal.h	(revision 75655)
+++ chrome/common/gpu_messages_internal.h	(working copy)
@@ -179,6 +179,13 @@
 // GPU Channel Messages
 // These are messages from a renderer process to the GPU process.
 
+// Initialize a channel between a renderer process and a GPU process. The
+// renderer passes a process handle to the GPU process, which gives it the

[Ken Russell (switch to Gerrit), 2011/02/24 19:48:47]

I found this really confusing to understand. I think a simple change to "The
renderer passes its process handle..." would help. Also, perhaps "gives the GPU
process the ability to map handles from the renderer process".

+// ability to map renderer handles into the GPU process. This must be the
+// first message sent on a newly connected channel.
+IPC_MESSAGE_CONTROL1(GpuChannelMsg_Initialize,
+                     base::ProcessHandle /* gpu_renderer_process */)

[Ken Russell (switch to Gerrit), 2011/02/24 19:48:47]

I found the naming convention of "gpu_renderer_process" throughout this CL
confusing, at least until finding another example ("browser_gpu_process"). Could
a different convention be used? How about "renderer_process_for_gpu"?

+
 // Tells the GPU process to create a new command buffer that renders to an
 // offscreen frame buffer. If parent_route_id is not zero, the texture backing
 // the frame buffer is mapped into the corresponding parent command buffer's
@@ -257,6 +264,13 @@
                            int32 /* size */,
                            int32 /* id */)
 
+// Register an existing shared memory transfer buffer. Returns an id that can be
+// used to identify the transfer buffer from a command buffer.
+IPC_SYNC_MESSAGE_ROUTED2_1(GpuCommandBufferMsg_RegisterTransferBuffer,
+                           base::SharedMemoryHandle /* transfer_buffer */,
+                           size_t /* size */,
+                           int32 /* id */)
+
 // Destroy a previously created transfer buffer.
 IPC_SYNC_MESSAGE_ROUTED1_0(GpuCommandBufferMsg_DestroyTransferBuffer,
                            int32 /* id */)