Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 6557004: Changing entry points to use cygwin python (as gyp will now fall back on... (Closed)

Created:
9 years, 10 months ago by bradn
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Changing entry points to use cygwin python (as gyp will now fall back on hermetic python). BUG=http://code.google.com/p/gyp/issues/detail?id=178 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75768

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M bootstrap/update_depot_tools.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
M gclient View 1 1 chunk +0 lines, -7 lines 0 comments Download
M update_depot_tools View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bradn
9 years, 10 months ago (2011-02-23 02:12:40 UTC) #1
Peter Kasting
Do drover and gcl need similar changes? Rubber-stamp LGTM (I'll test when you check in)
9 years, 10 months ago (2011-02-23 02:24:30 UTC) #2
bradn
I'm wary of touching drover especially, as I'm unsure if its cygwin safe (laforge isn't ...
9 years, 10 months ago (2011-02-23 02:27:39 UTC) #3
M-A Ruel
On 2011/02/23 02:27:39, bradn wrote: > I'm wary of touching drover especially, as I'm unsure ...
9 years, 10 months ago (2011-02-23 14:31:48 UTC) #4
bradn
9 years, 10 months ago (2011-02-23 18:50:17 UTC) #5
Ok, that's in.


On Wed, Feb 23, 2011 at 6:31 AM, <maruel@chromium.org> wrote:

> On 2011/02/23 02:27:39, bradn wrote:
>
>> I'm wary of touching drover especially, as I'm unsure if its cygwin safe
>> (laforge isn't around at the moment to ask, but I would guess its not).
>>
>
>  gcl seems to be a problem, as some of the presubmit hooks seems to hang
>> for
>> cygwin python (unfortunately the depot_tools PRESUBMITs maruel' added
>> recently), so I don't think we can change it.
>>
>
> thanks, lgtm
>
> I can try a quick look at gcl once you've committed, I'd like to get rid of
> native svn on cygwin.
>
>
> http://codereview.chromium.org/6557004/
>

Powered by Google App Engine
This is Rietveld 408576698