Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: client/bin/test.py

Issue 6557003: Modify autotest to support preserving minidumps generated during tests. (Closed) Base URL: http://git.chromium.org/git/autotest.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/cros/crash_test.py » ('j') | client/cros/crash_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/bin/test.py
diff --git a/client/bin/test.py b/client/bin/test.py
index 33f194ca39e955d030789b08ae8f89bda8f45cab..b172155a75b44444a48e497cfe7ac285f445d7ed 100644
--- a/client/bin/test.py
+++ b/client/bin/test.py
@@ -107,6 +107,24 @@ class test(common_test.base_test):
logging.warning('Please verify %s for more info', dir)
+ def _call_run_once(self, constraints, profile_only,
kmixter1 2011/02/23 02:00:39 Eric should comment on this since it's common code
+ postprocess_profiled_run, args, dargs):
+ """
+ The base class does not execute the after_iteration_hooks if a test
+ raises an exception. We want to override that behavior here since our
+ after_iteration_hooks collect important logs and crash information.
+ """
+ try:
+ common_test.base_test._call_run_once(self, constraints,
+ profile_only,
+ postprocess_profiled_run,
+ args, dargs)
+ except:
+ for hook in self.after_iteration_hooks:
ericli 2011/02/23 04:49:34 common_test.base_test._call_run_once() will also c
thieule 2011/03/03 01:27:41 Done.
+ hook(self)
+ raise
+
+
def runtest(job, url, tag, args, dargs):
common_test.runtest(job, url, tag, args, dargs, locals(), globals(),
job.sysinfo.log_before_each_test,
« no previous file with comments | « no previous file | client/cros/crash_test.py » ('j') | client/cros/crash_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698