Modify autotest to support preserving minidumps generated during tests.

server/site_server_job.py

+# Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import logging
+import os
+from autotest_lib.client.common_lib import utils as client_utils
+from autotest_lib.server import utils
+from autotest_lib.server.server_job import base_server_job
+
+
+class site_server_job(base_server_job):

[kmixter1, 2011/02/23 02:00:39]

Will this be used by all server tests automatically?

[thieule, 2011/03/03 01:27:41]

Yes.

+
+    def _generate_minidump_stacktrace(self, minidump_path):
+        symbol_dir = '%s/../../../lib/debug' % utils.get_server_dir()

[kmixter1, 2011/02/23 02:00:39]

I guess this only works for tests autotests run within build roots which does
cover a lot of important cases.  May be worth commenting where this expects
debug files to be in case we want to make sure the automatically run tests
(those by cautotest) also can generate minidumps.

[thieule, 2011/03/03 01:27:41]

Done.

+        logging.info('symbol_dir: %s' % symbol_dir)
+        result = client_utils.run('minidump_stackwalk %s %s > %s.txt' %
+                                  (minidump_path, symbol_dir, minidump_path))
+        return result.exit_status
+
+
+    def _find_and_generate_minidump_stacktraces(self):
+        for dir, subdirs, files in os.walk(self.resultdir):
+            for file in files:
+                if not file.endswith('.dmp'):
+                    continue
+                minidump = os.path.join(dir, file)
+                rc = self._generate_minidump_stacktrace(minidump)
+                if (rc == 0):

[kmixter1, 2011/02/23 02:00:39]

extra parens?

[thieule, 2011/03/03 01:27:41]

Done.

+                    logging.info('Generated stack trace for dump %s' %
+                                 minidump)
+                else:
+                    logging.error('Failed to generate stack trace for ' \
+                                  'dump %s (rc=%d)' % (minidump, rc))
+
+
+    def run(self, cleanup=False, install_before=False, install_after=False,
+            collect_crashdumps=True, namespace={}, control=None,
+            control_file_dir=None, only_collect_crashinfo=False):
+        """
+        Site specific implementation of base_server_job.run().
+
+        Override the base class implementation so we can perform some
+        of our own operations when the server job is completed.
+
+        See base_server_job.run() for more info.
+        """
+        try:
+            base_server_job.run(self, cleanup, install_before, install_after,
+                                collect_crashdumps, namespace, control,
+                                control_file_dir, only_collect_crashinfo)
+        finally:
+            self._find_and_generate_minidump_stacktraces()

[ericli, 2011/02/23 04:49:34]

There is already a try/finally block inside base_server_job.run() method.

Seems like you could:
1. Add _find_and_generate_minidump_stactraces() function to server/utils.py
2. Tnen make the call from CRASHDUMPS_CONTROL_FILE/CRASHINFO_CONTROL_FILE.

Then you could avoid this site_server_job file.

Take a  read server/crashcollec.py, it should be a better place to host these
functions.

[thieule, 2011/03/03 01:27:41]

Done.

I've moved the minidump generation to site_crashcollector.py.