Modify autotest to support preserving minidumps generated during tests.

server/server_job.py

 """
 The main job wrapper for the server side.
 
 This is the core infrastructure. Derived from the client side job.py
 
 Copyright Martin J. Bligh, Andy Whitcroft 2007
 """
 
 import getpass, os, sys, re, stat, tempfile, time, select, subprocess, platform
 import traceback, shutil, warnings, fcntl, pickle, logging, itertools, errno
@@ skipping 19 matching lines @@
 CLIENT_WRAPPER_CONTROL_FILE = _control_segment_path('client_wrapper')
 CRASHDUMPS_CONTROL_FILE = _control_segment_path('crashdumps')
 CRASHINFO_CONTROL_FILE = _control_segment_path('crashinfo')
 INSTALL_CONTROL_FILE = _control_segment_path('install')
 CLEANUP_CONTROL_FILE = _control_segment_path('cleanup')
 
 VERIFY_CONTROL_FILE = _control_segment_path('verify')
 REPAIR_CONTROL_FILE = _control_segment_path('repair')
 
 
-# by default provide a stub that generates no site data
-def _get_site_job_data_dummy(job):
-    return {}
-
-
-# load up site-specific code for generating site-specific job data
-get_site_job_data = utils.import_site_function(__file__,
-    "autotest_lib.server.site_server_job", "get_site_job_data",
-    _get_site_job_data_dummy)
-
-
 class status_indenter(base_job.status_indenter):
     """Provide a simple integer-backed status indenter."""
     def __init__(self):
         self._indent = 0
 
 
     @property
     def indent(self):
         return self._indent
 
@@ skipping 1040 matching lines @@
         self._state.discard_namespace('client')
 
 
     def clear_all_known_hosts(self):
         """Clears known hosts files for all AbstractSSHHosts."""
         for host in self.hosts:
             if isinstance(host, abstract_ssh.AbstractSSHHost):
                 host.clear_known_hosts()
 
 
+# by default provide a stub that generates no site data

[kmixter1, 2011/02/23 02:00:39]

was this just moved?  Were you just moving it to get it closer to point of use?

[thieule, 2011/03/03 01:27:41]

This block needed to be moved down because it imports site_server_job. 
site_server_job.py relies on base_server_job being declared.  With this block
being higher up in the file, base_server_job has not been declared yet.

Anyways, no need for this anymore since we're using site_crashcollector instead
of site_server_job.

+def _get_site_job_data_dummy(job):
+    return {}
+
+
+# load up site-specific code for generating site-specific job data
+get_site_job_data = utils.import_site_function(__file__,
+    "autotest_lib.server.site_server_job", "get_site_job_data",
+    _get_site_job_data_dummy)
+
+
 site_server_job = utils.import_site_class(
     __file__, "autotest_lib.server.site_server_job", "site_server_job",
     base_server_job)
 
 class server_job(site_server_job):
     pass
 
 
 class warning_manager(object):
     """Class for controlling warning logs. Manages the enabling and disabling
@@ skipping 19 matching lines @@
         intervals = self.disabled_warnings.setdefault(warning_type, [])
         if not intervals or intervals[-1][1] is not None:
             intervals.append((int(current_time_func()), None))
 
 
     def enable_warnings(self, warning_type, current_time_func=time.time):
         """As of now, enables all further warnings of this type."""
         intervals = self.disabled_warnings.get(warning_type, [])
         if intervals and intervals[-1][1] is None:
             intervals[-1] = (intervals[-1][0], int(current_time_func()))