Modify autotest to support preserving minidumps generated during tests.

client/cros/crash_test.py

 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging, os, re, shutil
 import common
 import cros_logging
 from autotest_lib.client.bin import test, utils
 from autotest_lib.client.common_lib import error
 
 
 class CrashTest(test.test):
 
     _CONSENT_FILE = '/home/chronos/Consent To Send Stats'
     _CORE_PATTERN = '/proc/sys/kernel/core_pattern'
     _CRASH_REPORTER_PATH = '/sbin/crash_reporter'
     _CRASH_SENDER_PATH = '/sbin/crash_sender'
     _CRASH_SENDER_RATE_DIR = '/var/lib/crash_sender'
     _CRASH_SENDER_RUN_PATH = '/var/run/crash_sender.pid'
+    _CRASH_TEST_IN_PROGRESS = '/tmp/crash-test-in-progress'

[kmixter1, 2011/02/23 02:00:39]

This is similar in use to _MOCK_CRASH_SENDING.  I can believe you can't reuse
it, but just want to make sure you've verified it.

[ericli, 2011/02/23 04:49:34]

any reason why not in constants.py?
On 2011/02/23 02:00:39, kmixter1 wrote:

[thieule, 2011/03/03 01:27:41]

_MOCK_CRASH_SENDING is set after the crash but before sending the info.  This is
unfortunately too late since I need to know if we're running crash tests while
handling the crash in UserCollector::HandleCrash().

[thieule, 2011/03/03 01:27:41]

I'm going to leave this constant in this file to be consistent with the rest of
the constants here.  We can have a separate CL that cleans up all these private
constants.

     _MOCK_CRASH_SENDING = '/tmp/mock-crash-sending'
     _PAUSE_FILE = '/var/lib/crash_sender_paused'
     _SYSTEM_CRASH_DIR = '/var/spool/crash'
     _USER_CRASH_DIR = '/home/chronos/user/crash'
 
     def _set_system_sending(self, is_enabled):
         """Sets whether or not the system crash_sender is allowed to run.
 
         crash_sender may still be allowed to run if _set_child_sending is
         called with true and it is run as a child process."""
@@ skipping 44 matching lines @@
 
 
     def _set_consent(self, has_consent):
         if has_consent:
             utils.open_write_close(self._CONSENT_FILE, 'test-consent')
             logging.info('Created ' + self._CONSENT_FILE)
         else:
             utils.system('rm -f "%s"' % (self._CONSENT_FILE))
 
 
+    def _set_crash_test_in_progress(self, in_progress):
+        if in_progress:
+            utils.open_write_close(self._CRASH_TEST_IN_PROGRESS, 'in-progress')
+            logging.info('Created ' + self._CRASH_TEST_IN_PROGRESS)
+        else:
+            utils.system('rm -f "%s"' % (self._CRASH_TEST_IN_PROGRESS))
+
+
     def _get_pushed_consent_file_path(self):
         return os.path.join(self.bindir, 'pushed_consent')
 
 
     def _push_consent(self):
         if os.path.exists(self._CONSENT_FILE):
             shutil.move(self._CONSENT_FILE,
                         self._get_pushed_consent_file_path())
 
 
@@ skipping 212 matching lines @@
     def disable_crash_filtering(self):
         self._replace_crash_reporter_filter_in('')
 
 
     def initialize(self):
         test.test.initialize(self)
         self._log_reader = cros_logging.LogReader()
         self._leave_crash_sending = True
         self._automatic_consent_saving = True
         self.enable_crash_filtering('none')
+        self._set_crash_test_in_progress(True)
 
 
     def cleanup(self):
         self._reset_rate_limiting()
         self._clear_spooled_crashes()
         self._set_system_sending(self._leave_crash_sending)
         self._set_sending_mock(mock_enabled=False)
         if self._automatic_consent_saving:
             self._pop_consent()
         self.disable_crash_filtering()
+        self._set_crash_test_in_progress(False)
         test.test.cleanup(self)
 
 
     def run_crash_tests(self,
                         test_names,
                         initialize_crash_reporter=False,
                         clear_spool_first=True,
                         must_run_all=True):
         """Run crash tests defined in this class.
 
@@ skipping 20 matching lines @@
                 self._initialize_crash_reporter()
             # Disable crash_sender from running, kill off any running ones, but
             # set environment so crash_sender may run as a child process.
             self._set_system_sending(False)
             self._set_child_sending(True)
             self._kill_running_sender()
             self._reset_rate_limiting()
             if clear_spool_first:
                 self._clear_spooled_crashes()
             getattr(self, '_test_' + test_name)()