Modify autotest to support preserving minidumps generated during tests.

client/bin/test.py

 # Copyright Martin J. Bligh, Andy Whitcroft, 2006
 #
 # Shell class for a test, inherited by all individual tests
 #
 # Methods:
 #       __init__        initialise
 #       initialize      run once for each job
 #       setup           run once for each new version of the test installed
 #       run             run the test (wrapped by job.run_test())
 #
@@ skipping 89 matching lines @@
             except EnvironmentError:
                 pass
             # Let the user know if core dumps were generated during the test
             core_dirs = glob.glob('%s/crash.*' % self.debugdir)
             if core_dirs:
                 logging.warning('Programs crashed during test execution')
                 for dir in core_dirs:
                     logging.warning('Please verify %s for more info', dir)
 
 
+    def _call_run_once(self, constraints, profile_only,

[kmixter1, 2011/02/23 02:00:39]

Eric should comment on this since it's common code and he's edited it more than
I have.

+                       postprocess_profiled_run, args, dargs):
+        """
+        The base class does not execute the after_iteration_hooks if a test
+        raises an exception.  We want to override that behavior here since our
+        after_iteration_hooks collect important logs and crash information.
+        """
+        try:
+            common_test.base_test._call_run_once(self, constraints,
+                                                 profile_only,
+                                                 postprocess_profiled_run,
+                                                 args, dargs)
+        except:
+            for hook in self.after_iteration_hooks:

[ericli, 2011/02/23 04:49:34]

common_test.base_test._call_run_once() will also call
self.after_iteration_hooks.  I would suggest you to directly patch into
ommon_test.base_test._call_run_once()  and try to upstream it.

I dont know if they will accept it or not but we at least should try.

[thieule, 2011/03/03 01:27:41]

Done.

+                hook(self)
+            raise
+
+
 def runtest(job, url, tag, args, dargs):
     common_test.runtest(job, url, tag, args, dargs, locals(), globals(),
                         job.sysinfo.log_before_each_test,
                         job.sysinfo.log_after_each_test,
                         job.sysinfo.log_before_each_iteration,
                         job.sysinfo.log_after_each_iteration)