Add more properties to crossystem

Add more properties to crossystem

crossystem now covers all data currently provided by chromeos_acpi.

Change-Id: I3364c4d65ddf63fe788d3d9c1e9d05e64be22856

BUG=chromium-os:12282
TEST=manual - test on Cr-48 and compare with ACPI values

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b47ed5a

[Bill Richardson, 2011-02-23 01:14:10]

Line 322 of crosssystem.c, you need a default case.

Otherwise, LGTM.

The codereview server is broken and keeps throwing python errors whenever I
try to submit my replies.

Bill




On Tue, Feb 22, 2011 at 5:03 PM, <rspangler@chromium.org> wrote:

> Reviewers: Bill Richardson,
>
> Description:
> Add more properties to crossystem
>
> crossystem now covers all data currently provided by chromeos_acpi.
>
> Change-Id: I3364c4d65ddf63fe788d3d9c1e9d05e64be22856
>
> BUG=12282
> TEST=manual - test on Cr-48 and compare with ACPI values
>
> Please review this at http://codereview.chromium.org/6557001/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master
>
> Affected files:
>  M host/lib/crossystem.c
>  M utility/crossystem_main.c
>
>
>


-- 
Art for Art's Sake
Engineering for Money

[Bill Richardson, 2011-02-23 01:15:34]

Line 322 of crosssystem.c, you need a default case.

Otherwise, LGTM.

The codereview server is broken and keeps throwing python errors whenever I
try to submit my replies.

Bill




On Tue, Feb 22, 2011 at 5:03 PM, <rspangler@chromium.org> wrote:

> Reviewers: Bill Richardson,
>
> Description:
> Add more properties to crossystem
>
> crossystem now covers all data currently provided by chromeos_acpi.
>
> Change-Id: I3364c4d65ddf63fe788d3d9c1e9d05e64be22856
>
> BUG=12282
> TEST=manual - test on Cr-48 and compare with ACPI values
>
> Please review this at http://codereview.chromium.org/6557001/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master
>
> Affected files:
>  M host/lib/crossystem.c
>  M utility/crossystem_main.c
>
>
>


-- 
Art for Art's Sake
Engineering for Money

[Randall Spangler, 2011-02-23 18:17:15]

On Tue, Feb 22, 2011 at 5:13 PM, Bill Richardson <wfrichar@chromium.org>wrote:

> Line 322 of crosssystem.c, you need a default case.


Seems a little silly to say:

   default:
     break; /* Fall through to check BINF.0 */

but adding that to conform to style guidelines.



>
> Otherwise, LGTM.
>
> The codereview server is broken and keeps throwing python errors whenever I
> try to submit my replies.
>
> Bill
>
>
>
>
> On Tue, Feb 22, 2011 at 5:03 PM, <rspangler@chromium.org> wrote:
>
>> Reviewers: Bill Richardson,
>>
>> Description:
>> Add more properties to crossystem
>>
>> crossystem now covers all data currently provided by chromeos_acpi.
>>
>> Change-Id: I3364c4d65ddf63fe788d3d9c1e9d05e64be22856
>>
>> BUG=12282
>> TEST=manual - test on Cr-48 and compare with ACPI values
>>
>> Please review this at http://codereview.chromium.org/6557001/
>>
>> SVN Base: ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master
>>
>> Affected files:
>>  M host/lib/crossystem.c
>>  M utility/crossystem_main.c
>>
>>
>>
>
>
> --
> Art for Art's Sake
> Engineering for Money
>
>
>