Used dashed-form for autofill overlay ids

chrome/browser/resources/options/autofill_edit_address_overlay.js

Index: chrome/browser/resources/options/autofill_edit_address_overlay.js
diff --git a/chrome/browser/resources/options/autofill_edit_address_overlay.js b/chrome/browser/resources/options/autofill_edit_address_overlay.js
index fe461f3e7ad4599586909eae97d3f8f4cb34aee6..8c61b06b2caa8d6a7bbe4f075e65e966243fc09d 100644
--- a/chrome/browser/resources/options/autofill_edit_address_overlay.js
+++ b/chrome/browser/resources/options/autofill_edit_address_overlay.js
@@ -14,9 +14,9 @@ cr.define('options', function() {
    * @class
    */
   function AutoFillEditAddressOverlay() {
-    OptionsPage.call(this, 'autoFillEditAddressOverlay',
+    OptionsPage.call(this, 'auto-fill-edit-address-overlay',
                      templateData.autoFillEditAddressTitle,
-                     'autoFillEditAddressOverlay');
+                     'auto-fill-edit-address-overlay');

[James Hawkins, 2011/02/23 02:35:42]

These two parameters aren't the same. Please read the jsdoc for
OptionsPage.call().

edit:
I now see that you were intending to change the 'name' of the page. This should
not be changed.

[Ilya Sherman, 2011/02/23 03:49:05]

Got it -- reverted the page name change.

   }
 
   cr.addSingletonGetter(AutoFillEditAddressOverlay);
@@ -31,10 +31,10 @@ cr.define('options', function() {
       OptionsPage.prototype.initializePage.call(this);
 
       var self = this;
-      $('autoFillEditAddressCancelButton').onclick = function(event) {
+      $('auto-fill-edit-address-cancel-button').onclick = function(event) {
         self.dismissOverlay_();
       }
-      $('autoFillEditAddressApplyButton').onclick = function(event) {
+      $('auto-fill-edit-address-apply-button').onclick = function(event) {
         self.saveAddress_();
         self.dismissOverlay_();
       }
@@ -63,13 +63,13 @@ cr.define('options', function() {
     saveAddress_: function() {
       var address = new Array();
       address[0] = this.guid;
-      address[1] = $('fullName').value;
-      address[2] = $('companyName').value;
-      address[3] = $('addrLine1').value;
-      address[4] = $('addrLine2').value;
+      address[1] = $('full-name').value;
+      address[2] = $('company-name').value;
+      address[3] = $('addr-line-1').value;
+      address[4] = $('addr-line-2').value;
       address[5] = $('city').value;
       address[6] = $('state').value;
-      address[7] = $('zipCode').value;
+      address[7] = $('zip-code').value;
       address[8] = $('country').value;
       address[9] = $('phone').value;
       address[10] = $('fax').value;
@@ -86,9 +86,9 @@ cr.define('options', function() {
      */
     connectInputEvents_: function() {
       var self = this;
-      $('fullName').oninput = $('companyName').oninput =
-      $('addrLine1').oninput = $('addrLine2').oninput = $('city').oninput =
-      $('state').oninput = $('country').oninput = $('zipCode').oninput =
+      $('full-name').oninput = $('company-name').oninput =
+      $('addr-line-1').oninput = $('addr-line-2').oninput = $('city').oninput =
+      $('state').oninput = $('country').oninput = $('zip-code').oninput =
       $('phone').oninput = $('fax').oninput =
       $('email').oninput = function(event) {
         self.inputFieldChanged_();
@@ -102,11 +102,12 @@ cr.define('options', function() {
      */
     inputFieldChanged_: function() {
       var disabled =
-          !$('fullName').value && !$('companyName').value &&
-          !$('addrLine1').value && !$('addrLine2').value && !$('city').value &&
-          !$('state').value && !$('zipCode').value && !('country').value &&
-          !$('phone').value && !$('fax').value && !$('email').value;
-      $('autoFillEditAddressApplyButton').disabled = disabled;
+          !$('full-name').value && !$('company-name').value &&
+          !$('addr-line-1').value && !$('addr-line-2').value &&
+          !$('city').value && !$('state').value && !$('zip-code').value &&
+          !$('country').value && !$('phone').value && !$('fax').value &&
+          !$('email').value;
+      $('auto-fill-edit-address-apply-button').disabled = disabled;
     },
 
     /**
@@ -114,13 +115,13 @@ cr.define('options', function() {
      * @private
      */
     clearInputFields_: function() {
-      $('fullName').value = '';
-      $('companyName').value = '';
-      $('addrLine1').value = '';
-      $('addrLine2').value = '';
+      $('full-name').value = '';
+      $('company-name').value = '';
+      $('addr-line-1').value = '';
+      $('addr-line-2').value = '';
       $('city').value = '';
       $('state').value = '';
-      $('zipCode').value = '';
+      $('zip-code').value = '';
       $('country').value = '';
       $('phone').value = '';
       $('fax').value = '';
@@ -143,13 +144,13 @@ cr.define('options', function() {
      * @private
      */
     setInputFields_: function(address) {
-      $('fullName').value = address['fullName'];
-      $('companyName').value = address['companyName'];
-      $('addrLine1').value = address['addrLine1'];
-      $('addrLine2').value = address['addrLine2'];
+      $('full-name').value = address['fullName'];
+      $('company-name').value = address['companyName'];
+      $('addr-line-1').value = address['addrLine1'];
+      $('addr-line-2').value = address['addrLine2'];
       $('city').value = address['city'];
       $('state').value = address['state'];
-      $('zipCode').value = address['zipCode'];
+      $('zip-code').value = address['zipCode'];
       $('country').value = address['country'];
       $('phone').value = address['phone'];
       $('fax').value = address['fax'];
@@ -166,7 +167,7 @@ cr.define('options', function() {
   };
 
   AutoFillEditAddressOverlay.setTitle = function(title) {
-    $('autoFillAddressTitle').textContent = title;
+    $('auto-fill-address-title').textContent = title;
   };
 
   // Export