Used dashed-form for autofill overlay ids

Used dashed-form for autofill overlay ids

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75724

[Ilya Sherman, 2011-02-23 00:47:45]

http://codereview.chromium.org/6552002/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6552002/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_address_overlay.html:1: <div
class="page hidden" id="autoFillEditAddressOverlay">
note: didn't change this id because all the examples I could find were in
camelCase -- should I change this one as well?

[James Hawkins, 2011-02-23 01:41:21]

http://codereview.chromium.org/6552002/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6552002/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_address_overlay.html:1: <div
class="page hidden" id="autoFillEditAddressOverlay">
On 2011/02/23 00:47:45, Ilya Sherman wrote:
> note: didn't change this id because all the examples I could find were in
> camelCase -- should I change this one as well?

Yes, but you'll have to change the corresponding js (the OptionsPage.call(...)).

[Ilya Sherman, 2011-02-23 01:52:54]

http://codereview.chromium.org/6552002/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6552002/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_address_overlay.html:1: <div
class="page hidden" id="autoFillEditAddressOverlay">
On 2011/02/23 01:41:21, James Hawkins wrote:
> On 2011/02/23 00:47:45, Ilya Sherman wrote:
> > note: didn't change this id because all the examples I could find were in
> > camelCase -- should I change this one as well?
> 
> Yes, but you'll have to change the corresponding js (the
OptionsPage.call(...)).

Ok, done.

[James Hawkins, 2011-02-23 02:35:42]

http://codereview.chromium.org/6552002/diff/7001/chrome/browser/resources/opt...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6552002/diff/7001/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_address_overlay.html:1: <div
class="page hidden" id="auto-fill-edit-address-overlay">
s/auto-fill/autofill/ here and elsewhere.

http://codereview.chromium.org/6552002/diff/7001/chrome/browser/resources/opt...
File chrome/browser/resources/options/autofill_edit_address_overlay.js (right):

http://codereview.chromium.org/6552002/diff/7001/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_address_overlay.js:19:
'auto-fill-edit-address-overlay');
These two parameters aren't the same. Please read the jsdoc for
OptionsPage.call().

edit:
I now see that you were intending to change the 'name' of the page. This should
not be changed.

[Ilya Sherman, 2011-02-23 03:49:05]

http://codereview.chromium.org/6552002/diff/7001/chrome/browser/resources/opt...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6552002/diff/7001/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_address_overlay.html:1: <div
class="page hidden" id="auto-fill-edit-address-overlay">
On 2011/02/23 02:35:42, James Hawkins wrote:
> s/auto-fill/autofill/ here and elsewhere.

Done.

http://codereview.chromium.org/6552002/diff/7001/chrome/browser/resources/opt...
File chrome/browser/resources/options/autofill_edit_address_overlay.js (right):

http://codereview.chromium.org/6552002/diff/7001/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_address_overlay.js:19:
'auto-fill-edit-address-overlay');
On 2011/02/23 02:35:42, James Hawkins wrote:
> These two parameters aren't the same. Please read the jsdoc for
> OptionsPage.call().
> 
> edit:
> I now see that you were intending to change the 'name' of the page. This
should
> not be changed.

Got it -- reverted the page name change.

[James Hawkins, 2011-02-23 04:05:43]

LGTM, thanks.

[arv (Not doing code reviews), 2011-02-23 17:58:10]

http://codereview.chromium.org/6552002/diff/6006/chrome/browser/resources/opt...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6552002/diff/6006/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_address_overlay.html:6:
<div><span i18n-content="fullNameLabel"></span></div>
My comment on the other patch was that in this case there is a div wrapping the
span and the code that other patch touched there is no div. We should probably
remove the divs here and below.

[Ilya Sherman, 2011-02-23 23:48:50]

http://codereview.chromium.org/6552002/diff/6006/chrome/browser/resources/opt...
File chrome/browser/resources/options/autofill_edit_address_overlay.html
(right):

http://codereview.chromium.org/6552002/diff/6006/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_address_overlay.html:6:
<div><span i18n-content="fullNameLabel"></span></div>
On 2011/02/23 17:58:10, arv wrote:
> My comment on the other patch was that in this case there is a div wrapping
the
> span and the code that other patch touched there is no div. We should probably
> remove the divs here and below.

Ah, ok: http://codereview.chromium.org/6575012/