Issue 6551022: Move lbase after lcrosapi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6551022: Move lbase after lcrosapi. (Closed)

Created:
9 years, 10 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, achuithb

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/image-burner.git@master

Visibility:
Public.

Description

Move lbase after lcrosapi. crosapi now depends on base for Time::Now(). Change-Id: I3b3df169b028455c71bf6a815ae8bb7d6bc788c1 BUG=none TEST=make sure image-burner builds on all platforms. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8ffdb0a

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

Small change (library order) required to add timing functions to libcros.

9 years, 10 months ago (2011-02-23 00:13:12 UTC) #1

achuithb

I didn't realize the order mattered - don't these libraries get linked in all at ...

9 years, 10 months ago (2011-02-23 18:34:08 UTC) #2

stevenjb

9 years, 10 months ago (2011-02-23 23:36:47 UTC) #3

On 2011/02/23 18:34:08, achuith.bhandarkar wrote:
> I didn't realize the order mattered - don't these libraries get linked in all
at
> once?
> 
> LGTM

Unfortunately, no. I believe there are ways to set that up, howver that does not
appear to be the case here.

Cheers.

Expand Messages | Collapse Messages