Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 6551008: ARM: Add support for just one string argument in the string add stub... (Closed)

Created:
9 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Add support for just one string argument in the string add stub Having a string add stub which can handle a string in just one of the arguments is essencial for the type recording binary operation stub when expecting strings. Otherwise string added with e.g. smi will always call the runtime for a type transition which will be back to the same types as the transition code keeps it in string arguments when one argument is a string. This fixes the regression (especially Delta Blue) caused by replacing the generic binary operation stub with the type recording binary operation stub in the ARM lithium code generator. Committed: http://code.google.com/p/v8/source/detail?r=6882

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -29 lines) Patch
M src/arm/code-stubs-arm.h View 1 chunk +19 lines, -7 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 8 chunks +95 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 10 months ago (2011-02-22 07:34:02 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-22 08:34:04 UTC) #2
LGTM

We need to port this to x64 as well.

Powered by Google App Engine
This is Rietveld 408576698