Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 6551002: Preload IME for the flash sandbox plugin... (Closed)

Created:
9 years, 10 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Preload IME for the flash sandbox plugin Before we lock down (call LowerToken()) we force the IME subsystem to load, so the required resources are acquired. Typical sites that show the issue are weathernews.jp and www.nicovideo.jp BUG=66605 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/plugin/plugin_main.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
.
9 years, 10 months ago (2011-02-21 22:02:46 UTC) #1
Hironori Bono
LGTM. I'm a little wondering if we may need to call ImmDestroyContext() to delete the ...
9 years, 10 months ago (2011-02-22 01:39:47 UTC) #2
cpu_(ooo_6.6-7.5)
Ideally we would, but I am concerned that under some conditions the resources needed for ...
9 years, 10 months ago (2011-02-22 02:31:15 UTC) #3
Hironori Bono
9 years, 10 months ago (2011-02-22 02:47:44 UTC) #4
Thank you so much for your description. It makes sense. :)

Regards,

Hironori Bono

On 2011/02/22 02:31:15, cpu wrote:
> Ideally we would, but I am concerned that under some conditions the resources
> needed for IME get closed and we end up in the same situation.
> 
> 
> On 2011/02/22 01:39:47, hbono wrote:
> > LGTM.
> > I'm a little wondering if we may need to call ImmDestroyContext() to delete
> the
> > context created by the ImmCreateContext(), though.
> > 
> > Regards,
> > 
> > Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698