Issue 6549037: Dup command-buffer SHM handle before auto-closing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6549037: Dup command-buffer SHM handle before auto-closing. (Closed)

Created:
9 years, 10 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Dup command-buffer SHM handle before auto-closing. This also adds error logging to the various places we close file descriptors, to help diagnosing future similar issues. BUG=none TEST=Pepper Flash + youtube in oop with --enable-accelerated-plugins Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75792

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -8 lines)			Patch
M	base/shared_memory_posix.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	base/sync_socket_posix.cc	View	2 chunks	+11 lines, -5 lines	0 comments	Download
M	ppapi/proxy/ppb_context_3d_proxy.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages