Issue 6549034: kernel build: use %U+1 for dm-verity booting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6549034: kernel build: use %U+1 for dm-verity booting (Closed)

Created:
9 years, 10 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
gauravsh, Bill Richardson

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

kernel build: use %U+1 for dm-verity booting Using %U+1 will ensure that we avoid device enumeration issues during recovery mode boots. TEST=build_image+dev recovery kernel and boot to it on new cros fw / fixed enumeration problem used build with mp recovery kernel on cr-48 -> installed then booted fine used dev recovery kernel on a legacy machine; installed fine, booted fine tested with cr-48, mp recovery kernel, and noenable_rootfs_verification to ensure /dev/sd%D%P still worked as normal. Change-Id: I5b1277a47536738a78c18988fd912cc05ebddd4b BUG=chromium-os:5470 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b910de8

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -15 lines)			Patch
M	bin/cros_make_image_bootable	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	build_kernel_image.sh	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	mod_image_for_recovery.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	update_bootloaders.sh	View	4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

Hey reviewers, I've cut over dm="" from using /dev/sd%D%P to using %U+1 to ensure that ...

9 years, 10 months ago (2011-02-23 01:40:46 UTC) #1

gauravsh

9 years, 10 months ago (2011-02-23 20:37:15 UTC) #3

LGTM

Can you file a bug on me referencing the CL to make parallel changes at the
signer's end? (I am guessing that until we completely switch over to this, I
will need to support both formats?)

Expand Messages | Collapse Messages