Issue 6549015: Extension half of the proxy error event

Issue 6549015: Extension half of the proxy error event (Closed)

Created:
9 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Bernhard Bauer, Matt Perry, battre

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/common/extensions/docs

Visibility:
Public.

Description

Extension half of the proxy error event BUG=71067 TEST=test is still disabled, pending network side changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75585

Patch Set 1 #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+444 lines, -16 lines)			Patch
M	chrome/browser/extensions/extension_io_event_router.h	View	2 chunks	+12 lines, -0 lines	1 comment	Download
M	chrome/browser/extensions/extension_io_event_router.cc	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_proxy_api.h	View	1 chunk	+21 lines, -0 lines	1 comment	Download
M	chrome/browser/extensions/extension_proxy_api.cc	View	3 chunks	+36 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_proxy_apitest.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.proxy.html	View	5 chunks	+281 lines, -16 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/proxy/events/manifest.json	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/proxy/events/test.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/proxy/events/test.js	View	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

Bernhard, please review Others, fyi this is the extension bits from http://codereview.chromium.org/6541021/ which only misses ...

9 years, 10 months ago (2011-02-22 12:28:50 UTC) #1

Bernhard Bauer

LGTM with a nit: http://codereview.chromium.org/6549015/diff/1/chrome/browser/extensions/extension_io_event_router.h File chrome/browser/extensions/extension_io_event_router.h (right): http://codereview.chromium.org/6549015/diff/1/chrome/browser/extensions/extension_io_event_router.h#newcode33 chrome/browser/extensions/extension_io_event_router.h:33: // Same as above, except ...

9 years, 10 months ago (2011-02-22 13:13:53 UTC) #2

jochen (gone - plz use gerrit)

9 years, 10 months ago (2011-02-22 13:24:40 UTC) #3

On 2011/02/22 13:13:53, Bernhard Bauer wrote:
> LGTM with a nit:
> 
>
http://codereview.chromium.org/6549015/diff/1/chrome/browser/extensions/exten...
> File chrome/browser/extensions/extension_io_event_router.h (right):
> 
>
http://codereview.chromium.org/6549015/diff/1/chrome/browser/extensions/exten...
> chrome/browser/extensions/extension_io_event_router.h:33: // Same as above,
> except the event is send to all extensions that have
> Nit: "sent".
> 
>
http://codereview.chromium.org/6549015/diff/1/chrome/browser/extensions/exten...
> File chrome/browser/extensions/extension_proxy_api.h (right):
> 
>
http://codereview.chromium.org/6549015/diff/1/chrome/browser/extensions/exten...
> chrome/browser/extensions/extension_proxy_api.h:20: class
> ExtensionProxyEventRouter {
> I guess this class is not used yet?

right, it's invoked from the network delegate which is part of the other cl

Expand Messages | Collapse Messages