Add a unittest for the CPU class....

Add a unittest for the CPU class.
This change just adds a unit test "CPU.RunExtendedInstructions" to base_unittests, which runs extended instructions for each CPU member function.

BUG=none
TEST=CPU.RunExtendedInstructions

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75861

[Hironori Bono, 2011-02-21 10:45:26]

Greetings,

This change just adds a unit test for the functions added by your r75150
<http://crrev.com/75150> to improve the test coverage. Even though this test may
not be your expected one, I wish it helps.

Regards,

Hironori Bono

[jiesun, 2011-02-22 17:11:40]

LGTM. thanks for doing this.
I was not able to think of any good test for this code in that time :)

[fbarchard, 2011-02-22 17:48:03]

http://codereview.chromium.org/6548003/diff/4001/base/cpu_unittest.cc
File base/cpu_unittest.cc (right):

http://codereview.chromium.org/6548003/diff/4001/base/cpu_unittest.cc#newcode20
base/cpu_unittest.cc:20: if (cpu.has_mmx()) {
mmx is required for chromium.  You could just assert on it.

[Hironori Bono, 2011-02-23 09:23:31]

Greetings Frank,

Thank you for your review and a comment. I have applied your comment. Is it
possible to take another look?

Regards,

Hironori Bono

http://codereview.chromium.org/6548003/diff/4001/base/cpu_unittest.cc
File base/cpu_unittest.cc (right):

http://codereview.chromium.org/6548003/diff/4001/base/cpu_unittest.cc#newcode20
base/cpu_unittest.cc:20: if (cpu.has_mmx()) {
On 2011/02/22 17:48:03, fbarchard wrote:
> mmx is required for chromium.  You could just assert on it.

Done. I have replaced this code with ASSERT_TRUE().