Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 6546081: Fix for the chrome frame anchor url navigation test failures. Fix is to appen... (Closed)

Created:
9 years, 10 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix for the chrome frame anchor url navigation test failures. Fix is to append the anchor portion of the url retrieved from the navigation manager to the url retrieved from the protocol sink wrapper. This is needed as the protocol sink wrapper sees the url without the anchor portion. BUG=71860 TEST=ChromeFrame anchor url tests. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75704

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome_frame/chrome_active_document.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 10 months ago (2011-02-23 01:04:08 UTC) #1
amit
9 years, 10 months ago (2011-02-23 19:32:17 UTC) #2
ok

On Tue, Feb 22, 2011 at 5:04 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix for the chrome frame anchor url navigation test failures. Fix is to
> append
> the anchor
> portion of the url retrieved from the navigation manager to the url
> retrieved
> from the
> protocol sink wrapper. This is needed as the protocol sink wrapper sees the
> url
> without
> the anchor portion.
>
> BUG=71860
> TEST=ChromeFrame anchor url tests.
>
>
> Please review this at http://codereview.chromium.org/6546081/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_active_document.cc
>
>
> Index: chrome_frame/chrome_active_document.cc
> ===================================================================
> --- chrome_frame/chrome_active_document.cc      (revision 75656)
> +++ chrome_frame/chrome_active_document.cc      (working copy)
> @@ -250,6 +250,16 @@
>   DCHECK(info);
>   if (info && !info->GetUrl().empty()) {
>     url = info->GetUrl();
> +    if (mgr) {
> +      // If the original URL contains an anchor, then the URL queried
> +      // from the protocol sink wrapper does not contain the anchor. To
> +      // workaround this we retrieve the anchor from the navigation
> manager
> +      // and append it to the url retrieved from the protocol sink
> wrapper.
> +      GURL url_for_anchor(mgr->url());
> +      if (url_for_anchor.has_ref()) {
> +        url += UTF8ToWide(url_for_anchor.ref());
> +      }
> +    }
>   } else {
>     // If the original URL contains an anchor, then the URL queried
>     // from the moniker does not contain the anchor. To workaround
>
>
>

Powered by Google App Engine
This is Rietveld 408576698