Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 6546080: Initialize the minimum timer interval upon RenderView construction,... (Closed)

Created:
9 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, jamesr
Visibility:
Public.

Description

Initialize the minimum timer interval upon RenderView construction, not during WebPreferences application, and base the interval on the initial hidden state of the view. This fixes a bug introduced late in the development of the minimum timer interval for background tabs, and also will fix http://code.google.com/p/chromium/issues/detail?id=73726 once the minimum timer interval is increased again. BUG=66078 TEST=manual tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75700

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/renderer/render_view.cc View 1 chunk +3 lines, -0 lines 1 comment Download
M webkit/glue/webpreferences.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
9 years, 10 months ago (2011-02-23 00:15:42 UTC) #1
darin (slow to review)
9 years, 10 months ago (2011-02-23 01:00:12 UTC) #2
LGTM

http://codereview.chromium.org/6546080/diff/1/chrome/renderer/render_view.cc
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/6546080/diff/1/chrome/renderer/render_view.cc#...
chrome/renderer/render_view.cc:631: webkit_glue::kForegroundTabTimerInterval);
nit: it is more common to indent this line so that the two values are vertically
on top of one another:

  is_hidden() ? webkit_glue::kBackgroundTabTimerInterval :
                webkit_glue::kForegroundTabTimerInterval;

Powered by Google App Engine
This is Rietveld 408576698