Issue 6546062: Up process priority during login.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6546062: Up process priority during login. (Closed)

Created:
9 years, 10 months ago by DaleCurtis

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Up process priority during login. We're seeing replicated characters during login which cause login failures. The general suspicion is autox being descheduled between KeyPress and KeyRelease events. Testing with increased priority caused the login failures to disappear. Sadly the occassional login timeout error seems unaffected. Also removed Tab between fields per old todo since Alt+P is available to focus the password field now. Change-Id: I44a431df1d27831075c5a9f198f8ee5848f586f5 BUG=chromium-os:12265 TEST=Ran 30 login_LoginSuccess tests and a couple bvt runs. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cfa8a60

Patch Set 1 #

Patch Set 2 : Upped priority to 20. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -18 lines)			Patch
	M	client/cros/login.py	View	1	2 chunks	+26 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

9 years, 10 months ago (2011-02-22 20:57:48 UTC) #3

In last minute testing I got an incorrect creds error. I retested with +2, +5,
+10 and was still getting the occasional failure. It's now been soaking with +20
for 15 minutes without fail. I'll let it run over lunch and if there are no
errors I'll push.

On 2011/02/22 19:51:15, Chris Masone wrote:
> sure, this LGTM.  Let's see how we do :-)

Expand Messages | Collapse Messages