Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: content/browser/renderer_host/render_message_filter.h

Issue 6546051: Created a new BrowserMessageFilter to handle print related IPC messages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.h
diff --git a/content/browser/renderer_host/render_message_filter.h b/content/browser/renderer_host/render_message_filter.h
index b8214665dec3984664ea9bb7800264d51cc6481f..c76b8eefc5af731f8bd6c81ae651315d70e4f79b 100644
--- a/content/browser/renderer_host/render_message_filter.h
+++ b/content/browser/renderer_host/render_message_filter.h
@@ -54,13 +54,6 @@ namespace net {
class CookieStore;
}
-namespace printing {
-class PrinterQuery;
-class PrintJobManager;
-}
-
-struct ViewHostMsg_ScriptedPrint_Params;
-
// This class filters out incoming IPC messages for the renderer process on the
// IPC thread.
class RenderMessageFilter : public BrowserMessageFilter,
@@ -216,27 +209,6 @@ class RenderMessageFilter : public BrowserMessageFilter,
void OnRevealFolderInOS(const FilePath& path);
void OnGetCPBrowsingContext(uint32* context);
-#if defined(OS_WIN)
- // Used to pass resulting EMF from renderer to browser in printing.
- void OnDuplicateSection(base::SharedMemoryHandle renderer_handle,
- base::SharedMemoryHandle* browser_handle);
-#endif
-
-#if defined(OS_CHROMEOS)
- // Used to ask the browser allocate a temporary file for the renderer
- // to fill in resulting PDF in renderer.
- void OnAllocateTempFileForPrinting(IPC::Message* reply_msg);
- void OnTempFileForPrintingWritten(int sequence_number);
-#endif
-
-#if defined(OS_POSIX)
- // Used to ask the browser to allocate a block of shared memory for the
- // renderer to send back data in, since shared memory can't be created
- // in the renderer on POSIX due to the sandbox.
- void OnAllocateSharedMemoryBuffer(uint32 buffer_size,
- base::SharedMemoryHandle* handle);
-#endif
-
void OnResourceTypeStats(const WebKit::WebCache::ResourceTypeStats& stats);
static void OnResourceTypeStatsOnUIThread(
const WebKit::WebCache::ResourceTypeStats&,
@@ -264,24 +236,6 @@ class RenderMessageFilter : public BrowserMessageFilter,
int result,
const std::string& proxy_list);
- // A javascript code requested to print the current page. This is done in two
- // steps and this is the first step. Get the print setting right here
- // synchronously. It will hang the I/O completely.
- void OnGetDefaultPrintSettings(IPC::Message* reply_msg);
- void OnGetDefaultPrintSettingsReply(
- scoped_refptr<printing::PrinterQuery> printer_query,
- IPC::Message* reply_msg);
-
- // A javascript code requested to print the current page. The renderer host
- // have to show to the user the print dialog and returns the selected print
- // settings.
- void OnScriptedPrint(const ViewHostMsg_ScriptedPrint_Params& params,
- IPC::Message* reply_msg);
- void OnScriptedPrintReply(
- scoped_refptr<printing::PrinterQuery> printer_query,
- int routing_id,
- IPC::Message* reply_msg);
-
// Browser side transport DIB allocation
void OnAllocTransportDIB(size_t size,
bool cache_in_browser,
@@ -355,8 +309,6 @@ class RenderMessageFilter : public BrowserMessageFilter,
IPC::Message* reply_msg);
void DoOnClipboardReadFilenames(ui::Clipboard::Buffer buffer,
IPC::Message* reply_msg);
- void DoOnAllocateTempFileForPrinting(IPC::Message* reply_msg);
- void DoOnTempFileForPrintingWritten(int sequence_number);
#endif
bool CheckBenchmarkingEnabled() const;
@@ -373,7 +325,6 @@ class RenderMessageFilter : public BrowserMessageFilter,
// by the BrowserProcess, which has a wider scope than we do.
ResourceDispatcherHost* resource_dispatcher_host_;
PluginService* plugin_service_;
- printing::PrintJobManager* print_job_manager_;
// The Profile associated with our renderer process. This should only be
// accessed on the UI thread!
@@ -405,8 +356,6 @@ class RenderMessageFilter : public BrowserMessageFilter,
// Whether this process is used for off the record tabs.
bool off_the_record_;
- bool cloud_print_enabled_;
-
base::TimeTicks last_plugin_refresh_time_; // Initialized to 0.
scoped_refptr<WebKitContext> webkit_context_;

Powered by Google App Engine
This is Rietveld 408576698