Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: src/factory.cc

Issue 6546036: Combine typed and pixel arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: feedback, propagate external array type Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index 96c757a373e9c11013ccbf943c6121de97934cad..dbdba75cfa96855cc14239dec34b7f44254d9049 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -250,13 +250,15 @@ Handle<ByteArray> Factory::NewByteArray(int length, PretenureFlag pretenure) {
}
-Handle<PixelArray> Factory::NewPixelArray(int length,
- uint8_t* external_pointer,
- PretenureFlag pretenure) {
+Handle<ExternalPixelArray> Factory::NewExternalPixelArray(
Kevin Millikin (Chromium) 2011/03/07 15:41:45 Is there a reason not to combine this with Factory
danno 2011/03/08 10:01:56 Done.
+ int length,
+ uint8_t* external_pointer,
+ PretenureFlag pretenure) {
ASSERT(0 <= length);
- CALL_HEAP_FUNCTION(Heap::AllocatePixelArray(length,
- external_pointer,
- pretenure), PixelArray);
+ CALL_HEAP_FUNCTION(
+ Heap::AllocateExternalPixelArray(length,
+ external_pointer,
+ pretenure), ExternalPixelArray);
}
@@ -334,8 +336,8 @@ Handle<Map> Factory::GetSlowElementsMap(Handle<Map> src) {
}
-Handle<Map> Factory::GetPixelArrayElementsMap(Handle<Map> src) {
- CALL_HEAP_FUNCTION(src->GetPixelArrayElementsMap(), Map);
+Handle<Map> Factory::NewExternalArrayElementsMap(Handle<Map> src) {
+ CALL_HEAP_FUNCTION(src->NewExternalArrayElementsMap(), Map);
}

Powered by Google App Engine
This is Rietveld 408576698