chrome/browser/sync/js_sync_manager_observer.cc - Issue 6546009: [Sync] Fix bug in JsSyncManagerObserver leading to erroneous change info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/js_sync_manager_observer.cc

Issue 6546009: [Sync] Fix bug in JsSyncManagerObserver leading to erroneous change info. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/js_sync_manager_observer.cc

diff --git a/chrome/browser/sync/js_sync_manager_observer.cc b/chrome/browser/sync/js_sync_manager_observer.cc

index 407ce98c2e147768af91b475969d3e5aebad2e38..ef6eb0696cc362267a538707bfba531531ab9425 100644

--- a/chrome/browser/sync/js_sync_manager_observer.cc

+++ b/chrome/browser/sync/js_sync_manager_observer.cc

@@ -34,7 +34,7 @@ void JsSyncManagerObserver::OnChangesApplied(

ListValue* change_values = new ListValue();

return_args.Append(change_values);

for (int i = 0; i < change_count; ++i) {

- change_values->Append(changes->ToValue(trans));

+ change_values->Append(changes[i].ToValue(trans));

}

parent_router_->RouteJsEvent("onChangesApplied",

JsArgList(return_args), NULL);

« no previous file with comments | « no previous file | chrome/browser/sync/js_sync_manager_observer_unittest.cc » ('j') | no next file with comments »