[Sync] Fix bug in JsSyncManagerObserver leading to erroneous change info.

[Sync] Fix bug in JsSyncManagerObserver leading to erroneous change info.

The bug is that the changes in an onChangesApplied() event is set to
n copies of the first change.

Fix similar bug in test code (which is why this bug wasn't caught).

BUG=69500
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75373

[akalin, 2011-02-18 05:03:29]

+nzea for review

[Nicolas Zea, 2011-02-18 06:09:52]

LGTM with a comment

http://codereview.chromium.org/6546009/diff/1/chrome/browser/sync/js_sync_man...
File chrome/browser/sync/js_sync_manager_observer_unittest.cc (right):

http://codereview.chromium.org/6546009/diff/1/chrome/browser/sync/js_sync_man...
chrome/browser/sync/js_sync_manager_observer_unittest.cc:226: // Fire
OnChangesApplied() for each data type.
A comment here about the fact that you're building a list of changes _starting_
with that specified datatype and including all datatypes higher than it would be
useful. It took me a bit to figure out why the expectations involved multiple
datatypes (since OnChangesApplied refers to only one datatype).

[akalin, 2011-02-18 08:12:18]

Checking in after trybots pass.

On 2011/02/18 06:09:52, nzea wrote:
> LGTM with a comment
> 
>
http://codereview.chromium.org/6546009/diff/1/chrome/browser/sync/js_sync_man...
> File chrome/browser/sync/js_sync_manager_observer_unittest.cc (right):
> 
>
http://codereview.chromium.org/6546009/diff/1/chrome/browser/sync/js_sync_man...
> chrome/browser/sync/js_sync_manager_observer_unittest.cc:226: // Fire
> OnChangesApplied() for each data type.
> A comment here about the fact that you're building a list of changes
_starting_
> with that specified datatype and including all datatypes higher than it would
be
> useful. It took me a bit to figure out why the expectations involved multiple
> datatypes (since OnChangesApplied refers to only one datatype).

[akalin, 2011-02-18 08:12:29]

http://codereview.chromium.org/6546009/diff/1/chrome/browser/sync/js_sync_man...
File chrome/browser/sync/js_sync_manager_observer_unittest.cc (right):

http://codereview.chromium.org/6546009/diff/1/chrome/browser/sync/js_sync_man...
chrome/browser/sync/js_sync_manager_observer_unittest.cc:226: // Fire
OnChangesApplied() for each data type.
On 2011/02/18 06:09:52, nzea wrote:
> A comment here about the fact that you're building a list of changes
_starting_
> with that specified datatype and including all datatypes higher than it would
be
> useful. It took me a bit to figure out why the expectations involved multiple
> datatypes (since OnChangesApplied refers to only one datatype).

Added comment, but above the expectations too since it involves that too.