Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3612)

Unified Diff: chrome/service/service_utility_process_host.cc

Issue 6544028: Create a Factory for NativeMetafile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed styling issues (naming, 80cols) Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/service_utility_process_host.cc
diff --git a/chrome/service/service_utility_process_host.cc b/chrome/service/service_utility_process_host.cc
index b63e27f9d7f8661de5f11428c9effe780a826320..cec2e681c943e0ddeefcbb2e20669c7965b1056d 100644
--- a/chrome/service/service_utility_process_host.cc
+++ b/chrome/service/service_utility_process_host.cc
@@ -9,11 +9,12 @@
#include "base/file_util.h"
#include "base/message_loop.h"
#include "base/message_loop_proxy.h"
+#include "base/scoped_ptr.h"
#include "base/scoped_temp_dir.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/utility_messages.h"
#include "ipc/ipc_switches.h"
-#include "printing/native_metafile.h"
vandebo (ex-Chrome) 2011/02/22 22:18:16 Still used.
dpapad 2011/02/23 00:44:39 Done.
+#include "printing/metafile_factory.h"
#include "printing/page_range.h"
#include "ui/base/ui_base_switches.h"
#include "ui/gfx/rect.h"
@@ -202,13 +203,15 @@ void ServiceUtilityProcessHost::Client::MetafileAvailable(
if (!scratch_metafile_dir.Set(metafile_path.DirName()))
LOG(WARNING) << "Unable to set scratch metafile directory";
#if defined(OS_WIN)
- printing::NativeMetafile metafile;
- if (!metafile.CreateFromFile(metafile_path)) {
+ scoped_ptr<printing::NativeMetafile> metafile(
+ printing::MetafileFactory::GetMetafile());
+ if (!metafile->CreateFromFile(metafile_path)) {
OnRenderPDFPagesToMetafileFailed();
} else {
- OnRenderPDFPagesToMetafileSucceeded(metafile, highest_rendered_page_number);
+ OnRenderPDFPagesToMetafileSucceeded(*metafile.get(),
+ highest_rendered_page_number);
// Close it so that ScopedTempDir can delete the folder.
- metafile.CloseEmf();
+ metafile->CloseEmf();
}
#endif // defined(OS_WIN)
}

Powered by Google App Engine
This is Rietveld 408576698