chrome/browser/printing/print_view_manager.cc - Issue 6544028: Create a Factory for NativeMetafile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 6544028: Create a Factory for NativeMetafile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed styling issues (naming, 80cols) Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_view_manager.cc

diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc

index 15cef0a3bea5a163e717c6d856dee9feff8ae291..8f31c2f5e4fa3d96feacfe488d98f55d5f5821c5 100644

--- a/chrome/browser/printing/print_view_manager.cc

+++ b/chrome/browser/printing/print_view_manager.cc

@@ -18,7 +18,7 @@

#include "chrome/common/render_messages.h"

#include "chrome/common/render_messages_params.h"

#include "grit/generated_resources.h"

-#include "printing/native_metafile.h"

+#include "printing/metafile_factory.h"

#include "printing/printed_document.h"

#include "ui/base/l10n/l10n_util.h"

@@ -124,7 +124,7 @@ void PrintViewManager::OnDidPrintPage(

#if defined(OS_POSIX) && !defined(OS_MACOSX)

NOTIMPLEMENTED() << " this printing code doesn't quite work yet.";

#else

- scoped_ptr<NativeMetafile> metafile(new NativeMetafile());

+ scoped_ptr<NativeMetafile> metafile(printing::MetafileFactory::GetMetafile());

vandebo (ex-Chrome) 2011/02/22 22:18:16 We're already in the printing namespace, you proba

dpapad 2011/02/23 00:44:39 Done.

if (!metafile->Init(shared_buf.memory(), params.data_size)) {

NOTREACHED() << "Invalid metafile header";

tab_contents()->Stop();