Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: printing/native_metafile.h

Issue 6544028: Create a Factory for NativeMetafile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ficed Mac unit tests, removed unnecessary include. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/native_metafile.h
diff --git a/printing/native_metafile.h b/printing/native_metafile.h
index b0f957a71fa3cf84410897f1be7a714499f3ebf5..e21723a205dcee048b3af2f50b2a556924a3d172 100644
--- a/printing/native_metafile.h
+++ b/printing/native_metafile.h
@@ -1,50 +1,18 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef PRINTING_NATIVE_METAFILE_H_
#define PRINTING_NATIVE_METAFILE_H_
-#include "build/build_config.h"
-
-// Define a metafile format for the current platform. We use this platform
-// independent define so we can define interfaces in platform agnostic manner.
-// It is still an outstanding design issue whether we create classes on all
-// platforms that have the same interface as Emf or if we change Emf to support
-// multiple platforms (and rename to NativeMetafile).
-
+#include "base/basictypes.h"
vandebo (ex-Chrome) 2011/02/28 21:44:00 nit: should stay build/build_config.h no?
dpapad 2011/02/28 22:03:38 I guess it has to stay.
#if defined(OS_WIN)
-
-#include "printing/emf_win.h"
-
-namespace printing {
-
-typedef Emf NativeMetafile;
-
-} // namespace printing
-
+#include "printing/native_metafile_win.h"
#elif defined(OS_MACOSX)
-
-#include "printing/pdf_metafile_mac.h"
-
-namespace printing {
-
-typedef PdfMetafile NativeMetafile;
-
-} // namespace printing
-
+#include "printing/native_metafile_mac.h"
#elif defined(OS_POSIX)
-
-#include "printing/pdf_ps_metafile_cairo.h"
-
-namespace printing {
-
-typedef PdfPsMetafile NativeMetafile;
-
-} // namespace printing
-
+#include "printing/native_metafile_linux.h"
#endif
-
#endif // PRINTING_NATIVE_METAFILE_H_

Powered by Google App Engine
This is Rietveld 408576698