Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 6544028: Create a Factory for NativeMetafile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ficed Mac unit tests, removed unnecessary include. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/plugin/webplugin_delegate_stub.cc » ('j') | printing/native_metafile.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_view_manager.cc
diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc
index 8eeba7ddb56a5dff7b8be192d397f18205c4936a..d53bd1675c1129facea0a30bc55b82ddf70dc2d5 100644
--- a/chrome/browser/printing/print_view_manager.cc
+++ b/chrome/browser/printing/print_view_manager.cc
@@ -19,6 +19,7 @@
#include "chrome/common/render_messages_params.h"
#include "grit/generated_resources.h"
#include "printing/native_metafile.h"
+#include "printing/native_metafile_factory.h"
James Hawkins 2011/02/28 22:26:45 nit: The rule for alphabetizing includes is to rem
dpapad 2011/02/28 23:50:59 Done.
#include "printing/printed_document.h"
#include "ui/base/l10n/l10n_util.h"
@@ -130,7 +131,7 @@ void PrintViewManager::OnDidPrintPage(
}
}
- scoped_ptr<NativeMetafile> metafile(new NativeMetafile());
+ scoped_ptr<NativeMetafile> metafile(NativeMetafileFactory::CreateMetafile());
if (metafile_must_be_valid) {
if (!metafile->Init(shared_buf.memory(), params.data_size)) {
NOTREACHED() << "Invalid metafile header";
« no previous file with comments | « no previous file | chrome/plugin/webplugin_delegate_stub.cc » ('j') | printing/native_metafile.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698