Create a Factory for NativeMetafile.

printing/emf_win_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/emf_win.h"
 
 // For quick access.
 #include <wingdi.h>
 #include <winspool.h>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/scoped_ptr.h"
 #include "base/scoped_temp_dir.h"
 #include "base/win/scoped_hdc.h"
+#include "printing/metafile_factory.h"
 #include "printing/printing_context.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 // This test is automatically disabled if no printer named "UnitTest Printer" is
 // available.
 class EmfPrintingTest : public testing::Test {
  public:
   typedef testing::Test Parent;
   static bool IsTestCaseDisabled() {
     // It is assumed this printer is a HP Color LaserJet 4550 PCL or 4700.
     HDC hdc = CreateDC(L"WINSPOOL", L"UnitTest Printer", NULL, NULL);
     if (!hdc)
       return true;
     DeleteDC(hdc);
     return false;
   }
 };
 
 const uint32 EMF_HEADER_SIZE = 128;
 
 }  // namespace
 
 TEST(EmfTest, DC) {
   // Simplest use case.
   printing::Emf emf;

[vandebo (ex-Chrome), 2011/02/22 22:18:16]

I know you haven't build windows yet, but it looks like this will fail.  You
could either use the factory, or make EmfPrintingTest a friend.

   RECT rect = {100, 100, 200, 200};
   HDC hdc = CreateCompatibleDC(NULL);
   EXPECT_TRUE(hdc != NULL);
   EXPECT_TRUE(emf.CreateDc(hdc, &rect));
   EXPECT_TRUE(emf.hdc() != NULL);
   // In theory, you'd use the HDC with GDI functions here.
   EXPECT_TRUE(emf.CloseDc());
   uint32 size = emf.GetDataSize();
   EXPECT_EQ(size, EMF_HEADER_SIZE);
   std::vector<BYTE> data;
@@ skipping 133 matching lines @@
   // Playback the data.
   hdc = CreateCompatibleDC(NULL);
   EXPECT_TRUE(hdc);
   EXPECT_TRUE(emf.CreateFromFile(metafile_path));
   RECT output_rect = {0, 0, 10, 10};
   EXPECT_TRUE(emf.Playback(hdc, &output_rect));
   EXPECT_TRUE(DeleteDC(hdc));
   emf.CloseEmf();
 }
 
+TEST(EmfTest, DCFactory) {

[vandebo (ex-Chrome), 2011/02/22 22:18:16]

Maybe put this next to DC.  You could pull out the common code to a shared
function.

[dpapad, 2011/02/23 00:44:39]

The unit test is basically identical, only the initialization of NativeMetafile
is different. I am merging them to a single unit test (should have done it from
the start).

+  // Simplest use case.
+  scoped_ptr<printing::NativeMetafile> emf(
+      printing::MetafileFactory::GetMetafile());
+  RECT rect = {100, 100, 200, 200};
+  HDC hdc = CreateCompatibleDC(NULL);
+  EXPECT_TRUE(hdc != NULL);
+  EXPECT_TRUE(emf->CreateDc(hdc, &rect));
+  EXPECT_TRUE(emf->hdc() != NULL);
+  // In theory, you'd use the HDC with GDI functions here.
+  EXPECT_TRUE(emf->CloseDc());
+  uint32 size = emf->GetDataSize();
+  EXPECT_EQ(size, EMF_HEADER_SIZE);
+  std::vector<BYTE> data;
+  EXPECT_TRUE(emf->GetData(&data));
+  EXPECT_EQ(data.size(), size);
+  emf->CloseEmf();
+  EXPECT_TRUE(DeleteDC(hdc));
+
+  // Playback the data.
+  hdc = CreateCompatibleDC(NULL);
+  EXPECT_TRUE(hdc);
+  EXPECT_TRUE(emf>Init(&data.front(), size));
+  RECT output_rect = {0, 0, 10, 10};
+  EXPECT_TRUE(emf->Playback(hdc, &output_rect));
+  EXPECT_TRUE(DeleteDC(hdc));
+}
+