Create a Factory for NativeMetafile.

chrome/renderer/webplugin_delegate_pepper.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define PEPPER_APIS_ENABLED 1
 
 #include "chrome/renderer/webplugin_delegate_pepper.h"
 
 #include <string>
 #include <vector>
@@ skipping 32 matching lines @@
 #include "chrome/renderer/renderer_sandbox_support_linux.h"
 #endif
 #include "chrome/renderer/webplugin_delegate_proxy.h"
 #include "ui/gfx/blit.h"
 #if defined(OS_WIN)
 #include "printing/units.h"
 #include "skia/ext/vector_platform_device.h"
 #include "ui/gfx/codec/jpeg_codec.h"
 #include "ui/gfx/gdi_util.h"
 #endif
-#include "printing/native_metafile.h"

[vandebo (ex-Chrome), 2011/02/22 22:18:16]

NativeMetafile is still used.

[dpapad, 2011/02/23 00:44:39]

Done.

+#include "printing/metafile_factory.h"
 #include "third_party/npapi/bindings/npapi_extensions.h"
 #include "third_party/npapi/bindings/npapi_extensions_private.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebCursorInfo.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
 #include "webkit/glue/webcursor.h"
 #include "webkit/glue/webkit_glue.h"
 #include "webkit/plugins/npapi/plugin_constants_win.h"
 #include "webkit/plugins/npapi/plugin_instance.h"
 #include "webkit/plugins/npapi/plugin_lib.h"
 #include "webkit/plugins/npapi/plugin_list.h"
@@ skipping 1151 matching lines @@
                                                   &pdf_output, &output_size);
   if (err != NPERR_NO_ERROR)
     return false;
 
   bool ret = false;
 #if defined(OS_LINUX)
   // On Linux we need to get the backing PdfPsMetafile and write the bits
   // directly.
   cairo_t* context = canvas->beginPlatformPaint();
   printing::NativeMetafile* metafile =
-      printing::NativeMetafile::FromCairoContext(context);
+      printing::MetafileFactory::GetMetafileFrom(context);

[vandebo (ex-Chrome), 2011/02/22 22:18:16]

This is cairo specific specific, so probably should go into the factory.  Can
you look into the details of what's going on here and then figure out what needs
to be done when we have two different ways to produce PDFs?

   DCHECK(metafile);
   if (metafile) {
     ret = metafile->SetRawData(pdf_output, output_size);
     if (ret)
       pdf_output_done_ = true;
   }
   canvas->endPlatformPaint();
 #elif defined(OS_MACOSX)
-  printing::NativeMetafile metafile;
+  scoped_ptr<printing::NativeMetafile> metafile(
+      printing::MetafileFactory::GetMetafile());
   // Create a PDF metafile and render from there into the passed in context.
-  if (metafile.Init(pdf_output, output_size)) {
+  if (metafile->Init(pdf_output, output_size)) {
     // Flip the transform.
     CGContextSaveGState(canvas);
     CGContextTranslateCTM(canvas, 0, current_printable_area_.height());
     CGContextScaleCTM(canvas, 1.0, -1.0);
-    ret = metafile.RenderPage(1, canvas, current_printable_area_.ToCGRect(),
+    ret = metafile->RenderPage(1, canvas, current_printable_area_.ToCGRect(),
                               true, false, true, true);
     CGContextRestoreGState(canvas);
   }
 #elif defined(OS_WIN)
   // On Windows, we now need to render the PDF to the DC that backs the
   // supplied canvas.
   skia::VectorPlatformDevice& device =
       static_cast<skia::VectorPlatformDevice&>(
           canvas->getTopPlatformDevice());
   HDC dc = device.getBitmapDC();
@@ skipping 508 matching lines @@
   CGRect bounds;
   bounds.origin.x = dest_rect.x();
   bounds.origin.y = canvas_height - dest_rect.y() - dest_rect.height();
   bounds.size.width = dest_rect.width();
   bounds.size.height = dest_rect.height();
 
   CGContextDrawImage(canvas, bounds, image);
   CGContextRestoreGState(canvas);
 }
 #endif  // defined(OS_MACOSX)