printing/native_metafile_factory.cc - Issue 6544028: Create a Factory for NativeMetafile.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: printing/native_metafile_factory.cc

Issue 6544028: Create a Factory for NativeMetafile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes for Mac Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "printing/native_metafile_factory.h"

	6
	vandebo (ex-Chrome) 2011/02/24 22:42:50 But the headers for the implementations need to be But the headers for the implementations need to be here. We prefer to minimize the number of includes in headers, pushing them into the .cc files where necessary. dpapad 2011/02/26 01:42:29 Done. Show quoted text On 2011/02/24 22:42:50, vandebo wrote: > But the headers for the implementations need to be here. > > We prefer to minimize the number of includes in headers, pushing them into the > .cc files where necessary. Done.
	7 namespace printing {

	8

	9 // static

	10 printing::NativeMetafile* NativeMetafileFactory::CreateMetafile() {

	11 #if defined(OS_WIN)

	12 return new printing::Emf;

	13 #elif defined(OS_MACOSX)

	14 return new printing::PdfMetafile;

	15 #elif defined(OS_POSIX)

	16 return new printing::PdfPsMetafile;

	17 #endif

	18 }

	19

	20 } // namespace printing

OLD	NEW