Issue 6544009: Merge 72458 - [SYNC] Speculative fix for autofill change processor destroying...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6544009: Merge 72458 - [SYNC] Speculative fix for autofill change processor destroying... (Closed)

Created:
9 years, 10 months ago by Nicolas Zea

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/branches/648/src/

Visibility:
Public.

Description

Merge 72458 - [SYNC] Speculative fix for autofill change processor destroying on the wrong thread. The data type manager should now tell any datatype controller that is not already stopping or not running to stop. Namely, this covers the MODEL_STARTING and ASSOCIATING cases, which weren't being covered before. Tests that can reproduce these race conditions still needed. BUG=61804 TEST=unit,sync_integration,self Review URL: http://codereview.chromium.org/6273011 TBR=zea@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75346

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/sync/glue/data_type_manager_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages