Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/test/webdriver/commands/execute_command.h

Issue 6544003: The command handler for /session/:sessionId/execute (execute_script) was... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/execute_command.h
===================================================================
--- chrome/test/webdriver/commands/execute_command.h (revision 75288)
+++ chrome/test/webdriver/commands/execute_command.h (working copy)
@@ -10,6 +10,8 @@
#include "chrome/test/webdriver/commands/webdriver_command.h"
+class ListValue;
+
namespace webdriver {
// Inject a snippet of javascript into the page and return its result.
@@ -33,8 +35,7 @@
virtual bool RequiresValidTab();
std::string script_;
- bool has_args_;
- std::string args_;
+ ListValue* args_; // Value is owned by |Command::parameters_|.
DISALLOW_COPY_AND_ASSIGN(ExecuteCommand);
};

Powered by Google App Engine
This is Rietveld 408576698