Implement the filesystem proxy. This allows the FileRef tests to pass in the...

webkit/plugins/ppapi/ppb_file_system_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_file_system_impl.h"
 
 #include "base/ref_counted.h"
 #include "ppapi/c/dev/ppb_file_system_dev.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPluginContainer.h"
 #include "webkit/fileapi/file_system_types.h"
+#include "webkit/plugins/ppapi/common.h"
 #include "webkit/plugins/ppapi/file_callbacks.h"
 #include "webkit/plugins/ppapi/plugin_delegate.h"
 #include "webkit/plugins/ppapi/plugin_module.h"
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 #include "webkit/plugins/ppapi/ppb_directory_reader_impl.h"
 #include "webkit/plugins/ppapi/resource.h"
 #include "webkit/plugins/ppapi/resource_tracker.h"
 
 namespace webkit {
 namespace ppapi {
 
 namespace {
 
 PP_Resource Create(PP_Instance instance, PP_FileSystemType_Dev type) {
   PluginInstance* plugin_instance =
       ResourceTracker::Get()->GetInstance(instance);
   if (!plugin_instance)
     return 0;
 
+  if (type != PP_FILESYSTEMTYPE_EXTERNAL &&
+      type != PP_FILESYSTEMTYPE_LOCALPERSISTENT &&
+      type != PP_FILESYSTEMTYPE_LOCALTEMPORARY)
+    return 0;
+
   PPB_FileSystem_Impl* file_system =
       new PPB_FileSystem_Impl(plugin_instance, type);
   return file_system->GetReference();
 }
 
+PP_Bool IsFileSystem(PP_Resource resource) {
+  scoped_refptr<PPB_FileSystem_Impl> file_system(
+      Resource::GetAs<PPB_FileSystem_Impl>(resource));
+  return BoolToPPBool(!!file_system.get());
+}
+
 int32_t Open(PP_Resource file_system_id,
              int64 expected_size,
              PP_CompletionCallback callback) {
   scoped_refptr<PPB_FileSystem_Impl> file_system(
       Resource::GetAs<PPB_FileSystem_Impl>(file_system_id));
   if (!file_system)
     return PP_ERROR_BADRESOURCE;
 
   if (file_system->opened())
     return PP_OK;
@@ skipping 10 matching lines @@
   if (!instance->delegate()->OpenFileSystem(
           instance->container()->element().document().frame()->url(),
           file_system_type, expected_size,
           new FileCallbacks(instance->module()->AsWeakPtr(), file_system_id,
                             callback, NULL, file_system, NULL)))
     return PP_ERROR_FAILED;
 
   return PP_ERROR_WOULDBLOCK;
 }
 
+PP_FileSystemType_Dev GetType(PP_Resource resource) {
+  scoped_refptr<PPB_FileSystem_Impl> file_system(
+      Resource::GetAs<PPB_FileSystem_Impl>(resource));
+  if (!file_system)
+    return PP_FILESYSTEMTYPE_NONE;

[vtl, 2011/02/21 19:06:00]

Maybe PP_FILESYSTEMTYPE_INVALID would be more appropriate?

(I'm tempted to say that it should be
int32_t GetType(PP_Resource, PP_FileSystemType_Dev* type);
so that errors can be reported, but that's a pain to use.)

[brettw, 2011/02/21 19:19:10]

Done.

+  return file_system->type();
+}
+
 const PPB_FileSystem_Dev ppb_filesystem = {
   &Create,
-  &Open
+  &IsFileSystem,
+  &Open,
+  &GetType
 };
 
 }  // namespace
 
 PPB_FileSystem_Impl::PPB_FileSystem_Impl(PluginInstance* instance,
                                          PP_FileSystemType_Dev type)
     : Resource(instance),
       instance_(instance),
       type_(type),
       opened_(false) {
+  DCHECK(type_ != PP_FILESYSTEMTYPE_NONE);
 }
 
 PPB_FileSystem_Impl* PPB_FileSystem_Impl::AsPPB_FileSystem_Impl() {
   return this;
 }
 
 const PPB_FileSystem_Dev* PPB_FileSystem_Impl::GetInterface() {
   return &ppb_filesystem;
 }
 
 }  // namespace ppapi
 }  // namespace webkit