Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 6543017: Track which apps the user has re-ordered on the NTP. (Closed)

Created:
9 years, 10 months ago by jstritar
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Track which apps the user has re-ordered on the NTP. BUG=73445 TEST=ExtensionPrefsAppDraggedByUser Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75497

Patch Set 1 #

Patch Set 2 : fix presubmit check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -7 lines) Patch
M chrome/browser/dom_ui/app_launcher_handler.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp/apps.js View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp/drag_drop_controller.js View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jstritar
9 years, 10 months ago (2011-02-18 20:52:06 UTC) #1
Erik does not do reviews
9 years, 10 months ago (2011-02-18 21:45:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698