[Mac] Fix cut-off Browser chrome when opening Tabpose with an infobar showing.

[Mac] Fix cut-off Browser chrome when opening Tabpose with an infobar showing.

BUG=73357
TEST=Get an infobar to show. Open Tab Overview/Tabpose. Everything looks correct.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75429

[Nico, 2011-02-18 20:03:21]

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.mm:2079: // visilbe again.
*visible

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.mm:2084: object:window];
Will this removeObserver: in the right order when chrome is closed with a
tabpose window open?

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/tabpose...
File chrome/browser/ui/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/tabpose...
chrome/browser/ui/cocoa/tabpose_window.mm:192: NSWindowController*
windowController = [window windowController];
DCHECK(windowController)

[Robert Sesek, 2011-02-18 20:18:00]

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.mm:2079: // visilbe again.
On 2011/02/18 20:03:21, Nico wrote:
> *visible

Done.

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.mm:2084: object:window];
On 2011/02/18 20:03:21, Nico wrote:
> Will this removeObserver: in the right order when chrome is closed with a
> tabpose window open?

There's a removeObserver: call in dealloc, so that should take care of this,
yes.

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/tabpose...
File chrome/browser/ui/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/6543012/diff/1/chrome/browser/ui/cocoa/tabpose...
chrome/browser/ui/cocoa/tabpose_window.mm:192: NSWindowController*
windowController = [window windowController];
On 2011/02/18 20:03:21, Nico wrote:
> DCHECK(windowController)

Done.

[Nico, 2011-02-18 20:53:21]

LG

you++

[Nico, 2011-03-04 07:34:20]

http://codereview.chromium.org/6543012/diff/6/chrome/browser/ui/cocoa/tabpose...
File chrome/browser/ui/cocoa/tabpose_window.mm (right):

http://codereview.chromium.org/6543012/diff/6/chrome/browser/ui/cocoa/tabpose...
chrome/browser/ui/cocoa/tabpose_window.mm:193: DCHECK(windowController);
I forgot that all background contents don't have a window, hence this DCHECKs
every time when someone opens tabpose with more than 1 tab open :-/

Also, if there's an infobar, the thumb gets pushed down too much; I guess you
don't want the full infobar height, just the part of it that doesn't overlap the
toolbar