Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4568)

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 6543010: Revert 75393 - Cancel prerender if any of the visited URLs are https.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_contents.cc
===================================================================
--- chrome/browser/prerender/prerender_contents.cc (revision 75394)
+++ chrome/browser/prerender/prerender_contents.cc (working copy)
@@ -48,11 +48,11 @@
has_stopped_loading_(false),
final_status_(FINAL_STATUS_MAX) {
DCHECK(prerender_manager != NULL);
- DCHECK(AddAliasURL(prerender_url_));
+ AddAliasURL(prerender_url_);
for (std::vector<GURL>::const_iterator it = alias_urls.begin();
it != alias_urls.end();
++it) {
- DCHECK(AddAliasURL(*it));
+ AddAliasURL(*it);
}
}
@@ -151,12 +151,9 @@
*p = params;
navigate_params_.reset(p);
- if (!AddAliasURL(params.url)) {
- Destroy(FINAL_STATUS_HTTPS);
- return;
- }
-
url_ = params.url;
+
+ AddAliasURL(url_);
}
void PrerenderContents::UpdateTitle(RenderViewHost* render_view_host,
@@ -343,19 +340,14 @@
void PrerenderContents::OnDidStartProvisionalLoadForFrame(int64 frame_id,
bool is_main_frame,
const GURL& url) {
- if (is_main_frame) {
- if (!AddAliasURL(url)) {
- Destroy(FINAL_STATUS_HTTPS);
- return;
- }
- }
+ if (is_main_frame)
+ AddAliasURL(url);
}
void PrerenderContents::OnDidRedirectProvisionalLoad(int32 page_id,
const GURL& source_url,
const GURL& target_url) {
- if (!AddAliasURL(target_url))
- Destroy(FINAL_STATUS_HTTPS);
+ AddAliasURL(target_url);
}
void PrerenderContents::OnUpdateFavIconURL(int32 page_id,
@@ -363,11 +355,8 @@
icon_url_ = icon_url;
}
-bool PrerenderContents::AddAliasURL(const GURL& url) {
- if (!url.SchemeIs("http"))
- return false;
+void PrerenderContents::AddAliasURL(const GURL& url) {
alias_urls_.push_back(url);
- return true;
}
bool PrerenderContents::MatchesURL(const GURL& url) const {
« no previous file with comments | « chrome/browser/prerender/prerender_contents.h ('k') | chrome/browser/prerender/prerender_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698