Issue 6543003: cocoa: Do not show up a tooltip when hovering on the magnifying glass on NTP.

Issue 6543003: cocoa: Do not show up a tooltip when hovering on the magnifying glass on NTP. (Closed)

Created:
9 years, 10 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Finnur, Nico

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

cocoa: Do not show up a tooltip when hovering on the magnifying glass on NTP. BUG=73252 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75352

Patch Set 3 : remove comment #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/6543003/diff/1/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm File chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm (right): http://codereview.chromium.org/6543003/diff/1/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm#newcode87 chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm:87: } Having tooltip_ is unnecessary now. Remove it, and ...

9 years, 10 months ago (2011-02-18 00:09:03 UTC) #2

tfarina

http://codereview.chromium.org/6543003/diff/1/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm File chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm (right): http://codereview.chromium.org/6543003/diff/1/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm#newcode87 chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm:87: } On 2011/02/18 00:09:03, Nico wrote: > Having tooltip_ ...

9 years, 10 months ago (2011-02-18 00:15:51 UTC) #3

Nico

lg http://codereview.chromium.org/6543003/diff/5001/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm File chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm (right): http://codereview.chromium.org/6543003/diff/5001/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm#newcode79 chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm:79: // the location bar is at the NTP. ...

9 years, 10 months ago (2011-02-18 00:23:12 UTC) #4

tfarina

9 years, 10 months ago (2011-02-18 02:09:37 UTC) #5

http://codereview.chromium.org/6543003/diff/5001/chrome/browser/ui/cocoa/loca...
File chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm (right):

http://codereview.chromium.org/6543003/diff/5001/chrome/browser/ui/cocoa/loca...
chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm:79: // the
location bar is at the NTP.
On 2011/02/18 00:23:13, Nico wrote:
> i'd remove the comment, it just repeats what the code says

Removed.

Expand Messages | Collapse Messages